fix: allow free USB targets in onboarding internal boot setup

[elibosley]

Summary

• remove the onboarding step's manual USB transport exclusion for internal boot targets
• keep free USB devices selectable in the internal boot setup flow
• update onboarding step tests to reflect USB devices remaining eligible when otherwise unassigned

Testing

• pnpm --filter web test -- --run web/test/components/Onboarding/OnboardingInternalBootStep.test.ts

Summary by CodeRabbit

• Bug Fixes
  • Fixed USB disk eligibility detection during boot setup. USB disks are now correctly recognized as valid boot targets instead of being marked as ineligible based on transport type.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7e7abe53-3b22-4f0f-9c08-6bd9a3604a46

📥 Commits

Reviewing files that changed from the base of the PR and between 8742cac and 0e6d751.

📒 Files selected for processing (2)

• web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts
• web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

---

Walkthrough

The changes remove USB transport-related ineligibility detection from the internal boot step component, allowing USB disks to be treated as eligible boot devices. Related test expectations are updated to reflect this behavior change.

Changes

Cohort / File(s)	Summary
Component Logic web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue	Removed USB_TRANSPORT from the InternalBootDiskEligibilityCode type union and its corresponding message key mapping. Eliminated logic that detects USB interface type and adds USB_TRANSPORT to ineligibility codes.
Test Expectations web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts	Updated test assertions to expect intro panel presence when storage boot is blocked, removed "no eligible devices" message assertion, added "usb-disk" to device selection list, and removed USB_TRANSPORT label expectations from test paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 wiggles nose
USB chains unbound at last,
Disks bloom where they were cast,
No more transport's harsh refrain,
Boot eligibility flows like rain! 🎉

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/allow-usb-internal-boot-onboarding

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.77%. Comparing base (8742cac) to head (0e6d751).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1903      +/-   ##
==========================================
- Coverage   50.78%   50.77%   -0.01%     
==========================================
  Files        1022     1022              
  Lines       70518    70513       -5     
  Branches     7647     7642       -5     
==========================================
- Hits        35811    35802       -9     
- Misses      34584    34588       +4     
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1903/dynamix.unraid.net.plg