Skip to content

New Crowdin updates#1912

Merged
elibosley merged 25 commits intomainfrom
l10n_main
Mar 16, 2026
Merged

New Crowdin updates#1912
elibosley merged 25 commits intomainfrom
l10n_main

Conversation

@elibosley
Copy link
Member

@elibosley elibosley commented Mar 15, 2026

Summary by CodeRabbit

  • Localization
    • Updated license transfer messaging across all supported languages to simplify the TPM (Trusted Platform Module) workflow.
    • Added new TPM GUID identification support and refined licensing flow terminology.
    • Replaced legacy TPM transfer descriptions with streamlined move-to-TPM messaging.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 41b210b4-62bd-48e3-812a-68fb1391e57b

📥 Commits

Reviewing files that changed from the base of the PR and between c3e9767 and 0a1803c.

📒 Files selected for processing (24)
  • web/src/locales/ar.json
  • web/src/locales/bn.json
  • web/src/locales/ca.json
  • web/src/locales/cs.json
  • web/src/locales/da.json
  • web/src/locales/de.json
  • web/src/locales/es.json
  • web/src/locales/fr.json
  • web/src/locales/hi.json
  • web/src/locales/hr.json
  • web/src/locales/hu.json
  • web/src/locales/it.json
  • web/src/locales/ja.json
  • web/src/locales/ko.json
  • web/src/locales/lv.json
  • web/src/locales/nl.json
  • web/src/locales/no.json
  • web/src/locales/pl.json
  • web/src/locales/pt.json
  • web/src/locales/ro.json
  • web/src/locales/ru.json
  • web/src/locales/sv.json
  • web/src/locales/uk.json
  • web/src/locales/zh.json

Walkthrough

Replaces TPM transfer-related localization keys with new TPM-license-movement keys across 23 language locale files. Removes detailed TPM transfer workflow messages and adds simplified keys for moving licenses to TPM and TPM GUID labeling.

Changes

Cohort / File(s) Summary
TPM Localization Refactor
web/src/locales/ar.json, web/src/locales/bn.json, web/src/locales/ca.json, web/src/locales/cs.json, web/src/locales/da.json, web/src/locales/de.json, web/src/locales/es.json, web/src/locales/fr.json, web/src/locales/hi.json, web/src/locales/hr.json, web/src/locales/hu.json, web/src/locales/it.json, web/src/locales/ja.json, web/src/locales/ko.json, web/src/locales/lv.json, web/src/locales/nl.json, web/src/locales/no.json, web/src/locales/pl.json, web/src/locales/pt.json, web/src/locales/ro.json, web/src/locales/ru.json, web/src/locales/sv.json, web/src/locales/uk.json, web/src/locales/zh.json
Removed 12 TPM transfer-related keys (availability, description, trial, steps, ready states) and added 3 new keys: registration.moveLicenseToTpm, registration.moveLicenseToTpmTrialDisabled, registration.tpmGuid. Consistent pattern applied uniformly across all 23 language files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • New Crowdin updates #1910: Adds the same registration.tpmTransfer* localization keys that this PR removes, indicating a direct conflict or reversal of changes across these two PRs.

Poem

🐰 Old transfer keys hop away to rest,
New "moveLicense" paths pass the test,
TPM GUID shines bright and clear,
Simplified flows bring cheer,
Locales updated, the world's blessed!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'New Crowdin updates' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the specific changes made. Replace the generic title with a specific description of the actual changes, such as 'Replace TPM transfer flow with move-to-TPM license keys across all locales' or 'Refactor TPM-related localization keys for license migration workflow'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch l10n_main
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.96%. Comparing base (c3e9767) to head (0a1803c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1912   +/-   ##
=======================================
  Coverage   50.96%   50.96%           
=======================================
  Files        1023     1023           
  Lines       70556    70556           
  Branches     7687     7687           
=======================================
  Hits        35956    35956           
  Misses      34476    34476           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1912/dynamix.unraid.net.plg

@elibosley elibosley merged commit 2daceab into main Mar 16, 2026
13 checks passed
@elibosley elibosley deleted the l10n_main branch March 16, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant