Skip to content

fix(release): honor workflow input tag#11

Merged
elibosley merged 1 commit into
mainfrom
codex/fix-release-workflow-input-tag
May 20, 2026
Merged

fix(release): honor workflow input tag#11
elibosley merged 1 commit into
mainfrom
codex/fix-release-workflow-input-tag

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented May 20, 2026

Summary

  • Fix reusable release validation to prefer an explicit workflow input tag.
  • Fall back to the triggering ref for tag-push validation.
  • Prevent release-please calls from validating main as the release tag.

Verification

Summary by CodeRabbit

  • Chores
    • Updated release workflow configuration for improved consistency in tag resolution during deployment procedures across different release contexts.

Review Change Stack

- Purpose: repair release validation when release-please calls the reusable release workflow.

- Before: the workflow looked at GITHUB_EVENT_NAME, which remains push inside reusable workflow calls, so it ignored inputs.tag and validated main as the release tag.

- Problem: release-please-created releases failed even though the caller supplied the correct SemVer tag.

- Now: checkout and validation prefer inputs.tag when present and fall back to the triggering ref for tag pushes.

- How: resolve RELEASE_TAG through the Actions expression context and read that value in the shell step.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1c8464af-0820-48fc-8c93-69ece1e6ca64

📥 Commits

Reviewing files that changed from the base of the PR and between 0948c37 and 3c219db.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow is updated to simplify tag resolution. The Checkout step now directly uses inputs.tag || github.ref, and the metadata validation step sets RELEASE_TAG from inputs.tag || github.ref_name, with the validation script reading from this unified environment variable instead of conditionally branching on GitHub event context.

Changes

Tag Resolution Unification

Layer / File(s) Summary
Checkout and validation tag resolution
.github/workflows/release.yml
Checkout uses `inputs.tag

🎯 2 (Simple) | ⏱️ ~8 minutes

🐰 A workflow once asked which tag to use,
Now it simply picks—no branching fuse!
Input or ref, the choice flows clean,
Simplest resolution code has seen. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix(release): honor workflow input tag' follows the conventional commits format with a 'fix:' prefix and clearly describes the main change: correcting the release workflow to properly use the workflow input tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-release-workflow-input-tag
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch codex/fix-release-workflow-input-tag

Comment @coderabbitai help to get the list of available commands and usage tips.

@elibosley elibosley merged commit 505519e into main May 20, 2026
3 checks passed
@elibosley elibosley deleted the codex/fix-release-workflow-input-tag branch May 20, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant