Conversation
📝 WalkthroughWalkthroughDocumentation updates: add a deprecation note in 7.0.0 release notes about the removed mover CLI option, add a new 7.2.1 release-notes doc with detailed changelog and guidance, and update the file-systems user guide to reflect WebGUI vs CLI mover behavior across versions. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant WebGUI
participant CLI as "CLI mover (-e)"
participant Docs as "Docs / Release Notes"
rect rgba(200,230,255,0.6)
Note over User,WebGUI: Recommended flow (7.2.1+)
User->>WebGUI: Use WebGUI to empty disk / trigger mover
WebGUI-->>User: Moves files per share settings
end
rect rgba(255,230,200,0.6)
Note over User,CLI: Legacy flow (7.0–7.1)
User->>CLI: Run mover -e (legacy)
CLI--x User: `-e` option removed in 7.2.1
end
Docs->>User: Release notes & guidance (7.0.0 deprecation, 7.2.1 changelog)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 LanguageTooldocs/unraid-os/release-notes/7.2.1.md[grammar] ~35-~35: Use a hyphen to join words. (QB_NEW_EN_HYPHEN) [style] ~54-~54: Consider changing the order of words to improve your wording. (TO_NOT_VB) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/unraid-os/release-notes/7.2.1.md (1)
54-54: Minor: Consider rephrasing for clarity.The phrase "patched to not exclude" is grammatically acceptable but slightly awkward. Consider rephrasing to "patched not to exclude" for more natural flow in technical documentation.
-- wsdd2-1.8.7-x86\_64-2\_SBo\_LT.tgz (patched to not exclude shim interfaces) +- wsdd2-1.8.7-x86\_64-2\_SBo\_LT.tgz (patched not to exclude shim interfaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/release-notes/7.2.1.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/unraid-os/release-notes/7.2.1.md
[style] ~54-~54: Consider changing the order of words to improve your wording.
Context: ...2-1.8.7-x86_64-2_SBo_LT.tgz (patched to not exclude shim interfaces)
(TO_NOT_VB)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy-preview
🔇 Additional comments (2)
docs/unraid-os/release-notes/7.2.1.md (2)
19-50: Comprehensive changelog with clear categorization.The changes are well-organized by component (webGUI, Storage, Misc, Linux kernel, Base distro updates). Descriptions are concise and action-oriented. The cross-reference at line 33 to the file-systems documentation for mover behavior is helpful for users transitioning from the command-line
-eoption to the webGUI workflow.
1-15: All relative links verified and valid.The verification confirms all internal documentation links resolve correctly:
- Links to upgrading, licensing FAQ, and file-systems documentation exist ✓
- References to 7.2.0 release notes (both
#known-issuesand#rolling-backanchors) are valid ✓The release notes follow proper documentation practices with relative path linking.
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/release-notes/7.2.1.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/unraid-os/release-notes/7.2.1.md
[grammar] ~35-~35: Use a hyphen to join words.
Context: ...uce excess logging related to drive spin down and SMART self-tests ### Misc - F...
(QB_NEW_EN_HYPHEN)
[style] ~54-~54: Consider changing the order of words to improve your wording.
Context: ...2-1.8.7-x86_64-2_SBo_LT.tgz (patched to not exclude shim interfaces)
(TO_NOT_VB)
🔇 Additional comments (2)
docs/unraid-os/release-notes/7.2.1.md (2)
1-54: Document structure and content are well-organized.The release notes follow proper documentation conventions with clear sections, appropriate heading hierarchy, and a comprehensive changelog organized by domain. The formatting is consistent with other Unraid release notes. The file naming (
7.2.1.md), location, and relative link usage align with the contribution checklist requirements.
1-54: Verify internal link paths before merge.The document uses relative links to internal wiki pages (e.g.,
7.2.0.md,upgrading-unraid.mdx,file-systems.mdx). Ensure all referenced files exist and the relative paths are correct in the deployed documentation structure.Run the following script to verify the referenced documentation files exist:
| - Fix: DeviceInfo: Only show 'Pool Device Status' section when pool is mounted | ||
| - Fix: Empty Disk feature: share data on target disk(s) now remains visible during operation, see [Converting to a new file system type](../using-unraid-to/manage-storage/file-systems.mdx#converting-to-a-new-file-system-type) for usage details. | ||
| - Removed '-e' option from 'mover' script; use the webGUI now | ||
| - Fix: Reduce excess logging related to drive spin down and SMART self-tests |
There was a problem hiding this comment.
Fix hyphenation in compound adjective.
The phrase "drive spin down" should be hyphenated as "drive spin-down" when used as a compound adjective modifying "logging."
Apply this diff:
-- Fix: Reduce excess logging related to drive spin down and SMART self-tests
+- Fix: Reduce excess logging related to drive spin-down and SMART self-tests📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Fix: Reduce excess logging related to drive spin down and SMART self-tests | |
| - Fix: Reduce excess logging related to drive spin-down and SMART self-tests |
🧰 Tools
🪛 LanguageTool
[grammar] ~35-~35: Use a hyphen to join words.
Context: ...uce excess logging related to drive spin down and SMART self-tests ### Misc - F...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
In docs/unraid-os/release-notes/7.2.1.md around line 35, the compound adjective
"drive spin down" should be hyphenated; change "drive spin down" to "drive
spin-down" in the sentence so it reads "Reduce excess logging related to drive
spin-down and SMART self-tests."
1 participant
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit