Fix: PR message incorrect removal instructions#2389
Conversation
WalkthroughUpdated the PR workflow’s generated comment in .github/workflows/pr-plugin-upload.yml to reference the PR number for uninstall instructions instead of the version, changing two occurrences under the "To Remove" section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pr-plugin-upload.yml (1)
362-365: Generator verified — plugin filename includes the .plg extension; align the workflow remove example.generate-pr-plugin.sh sets PLUGIN_NAME="webgui-pr-${PR_NUMBER}.plg" and replaces PR_PLACEHOLDER throughout, so the generated plugin file is webgui-pr-<PR_NUMBER>.plg (template names/paths become webgui-pr-<PR_NUMBER>).
- Update .github/workflows/pr-plugin-upload.yml (lines 362–365) to use:
plugin remove webgui-pr-${{ steps.metadata.outputs.pr_number }}.plg
or explicitly note that the Installed Plugins UI may display the name without the .plg extension.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pr-plugin-upload.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Squidly271
PR: unraid/webgui#0
File: :0-0
Timestamp: 2025-05-31T05:10:13.120Z
Learning: Squidly271 prefers not to receive CodeRabbit reviews or feedback while PRs are in draft status. Only provide reviews after PRs are moved out of draft.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🧹 PR Test Plugin Cleaned UpThe test plugin and associated files for this PR have been removed from the preview environment. 🤖 This comment is automatically generated when a PR is closed. |
Summary by CodeRabbit