Skip to content

Fix: bootvga check.#2436

Merged
limetech merged 1 commit intounraid:masterfrom
SimonFair:Bug-Language-issue-for-bootvga-value-
Oct 22, 2025
Merged

Fix: bootvga check.#2436
limetech merged 1 commit intounraid:masterfrom
SimonFair:Bug-Language-issue-for-bootvga-value-

Conversation

@SimonFair
Copy link
Copy Markdown
Contributor

@SimonFair SimonFair commented Oct 22, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Corrected GPU selection handling in VM configuration to ensure proper processing of GPU change events and correct visibility of related GPU options.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 22, 2025

Walkthrough

A JavaScript conditional in the GPU change handler was updated to compare against "virtual", "", and "nogpu" instead of "(virtual)", "", and "(nogpu)". The surrounding event handler logic remains unchanged.

Changes

Cohort / File(s) Change Summary
GPU label string literals
emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php
Updated GPU selection comparison values, removing underscores around "virtual" and "nogpu" labels in conditional check

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Underscores fled the GPU code,
Where comparisons took lighter load,
"Virtual" and "nogpu" now shine,
Without their quirky underline,
A simpler path for handlers true! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely highlights the primary change of repairing the bootvga check logic, directly reflecting the update to the GPU handler conditionals; it is sufficiently specific and clearly related to the core changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0eb5f95 and 171c6f6.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2025.10.22.2017
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2436/webgui-pr-2436.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2436, or run:

plugin remove webgui-pr-2436

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@limetech limetech merged commit 2fce67e into unraid:master Oct 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants