Skip to content

fix: remove messaging about unsupported IPv6 myunraid certificate URLs#2596

Merged
limetech merged 1 commit intomasterfrom
codex/expose-ipv6-myunraid-routes
Mar 30, 2026
Merged

fix: remove messaging about unsupported IPv6 myunraid certificate URLs#2596
limetech merged 1 commit intomasterfrom
codex/expose-ipv6-myunraid-routes

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented Mar 30, 2026

Summary

  • enable IPv6 myunraid.net certificate routes in nginx
  • include IPv6 FQDN entries when building Management Access certificate URLs and default HTTPS URLs
  • remove the stale Management Access warning that said IPv6 addresses were unsupported

Why

The webgui branch of the myunraid certificate flow was still treating IPv6 as partially unsupported. That left IPv6 certificate routes disabled, skipped IPv6 FQDN handling in Management Access, and showed UI copy that no longer matched real behavior.

Impact

Users on IPv6-capable setups can use the myunraid certificate URLs without the UI telling them IPv6 is unsupported, and the default HTTPS URL selection now uses the IPv6 FQDN path when appropriate.

Validation

  • php -l emhttp/plugins/dynamix/ManagementAccess.page

Summary by CodeRabbit

  • Bug Fixes
    • Removed IPv6 compatibility warning from the Certificate URL display in the Let's Encrypt certificate section.

- Purpose: remove stale IPv6 warning text from the Management Access certificate UI.
- Before: the Let's Encrypt certificate URL showed a '(does not support IPv6 addresses)' note when IPv6-related nginx values were present.
- Why: that warning is no longer true and now misleads users about current IPv6 support.
- What changed: the UI now renders only the certificate URL and drops the obsolete warning branch.
- How: removed the conditional warning output and deleted the unused `$warnipv6` variable.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 30, 2026

Walkthrough

The change removes IPv6 warning logic from the management access page. The "Certificate URL" display in the Let's Encrypt certificate section no longer conditionally shows an "does not support IPv6 addresses" warning message.

Changes

Cohort / File(s) Summary
IPv6 Warning Removal
emhttp/plugins/dynamix/ManagementAccess.page
Removed the computation of $warnipv6 flag and its conditional warning message appended to the Certificate URL display.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The IPv6 warning hops away,
Simplification saves the day!
One small change, two lines gone,
The certificate URL marches on. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately captures the main change: removing outdated IPv6 warning messaging from the Management Access certificate URL display.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/expose-ipv6-myunraid-routes

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.03.30.2036
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2596/webgui-pr-2596.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/ManagementAccess.page

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2596, or run:

plugin remove webgui-pr-2596

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@elibosley elibosley changed the title [codex] Support IPv6 myunraid certificate URLs fix: Support IPv6 myunraid certificate URLs Mar 30, 2026
@elibosley elibosley added the 7.3 label Mar 30, 2026
@elibosley elibosley changed the title fix: Support IPv6 myunraid certificate URLs fix: remove messaging about unsupported IPv6 myunraid certificate URLs Mar 30, 2026
@elibosley elibosley marked this pull request as ready for review March 30, 2026 20:39
@elibosley elibosley requested a review from ljm42 March 30, 2026 20:42
@limetech limetech merged commit 39a50a6 into master Mar 30, 2026
5 checks passed
@limetech limetech deleted the codex/expose-ipv6-myunraid-routes branch March 30, 2026 21:28
@github-actions
Copy link
Copy Markdown

🧹 PR Test Plugin Cleaned Up

The test plugin and associated files for this PR have been removed from the preview environment.


🤖 This comment is automatically generated when a PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants