fix: remove messaging about unsupported IPv6 myunraid certificate URLs#2596
fix: remove messaging about unsupported IPv6 myunraid certificate URLs#2596
Conversation
- Purpose: remove stale IPv6 warning text from the Management Access certificate UI. - Before: the Let's Encrypt certificate URL showed a '(does not support IPv6 addresses)' note when IPv6-related nginx values were present. - Why: that warning is no longer true and now misleads users about current IPv6 support. - What changed: the UI now renders only the certificate URL and drops the obsolete warning branch. - How: removed the conditional warning output and deleted the unused `$warnipv6` variable.
WalkthroughThe change removes IPv6 warning logic from the management access page. The "Certificate URL" display in the Let's Encrypt certificate section no longer conditionally shows an "does not support IPv6 addresses" warning message. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
🧹 PR Test Plugin Cleaned UpThe test plugin and associated files for this PR have been removed from the preview environment. 🤖 This comment is automatically generated when a PR is closed. |
Summary
Why
The webgui branch of the myunraid certificate flow was still treating IPv6 as partially unsupported. That left IPv6 certificate routes disabled, skipped IPv6 FQDN handling in Management Access, and showed UI copy that no longer matched real behavior.
Impact
Users on IPv6-capable setups can use the myunraid certificate URLs without the UI telling them IPv6 is unsupported, and the default HTTPS URL selection now uses the IPv6 FQDN path when appropriate.
Validation
php -l emhttp/plugins/dynamix/ManagementAccess.pageSummary by CodeRabbit