fix(docker): filter ghost containers from WebGUI#2611
Conversation
- Purpose: backport the Docker ghost/dead container filtering change to the 7.2 release branch. - Before: stale dead Docker entries could be included in the WebGUI container list and inspect failures could leak bad rows into the UI. - Problem: Docker shutdown races can leave orphaned metadata that users cannot act on, which makes the Docker page show ghost containers. - Change: skip invalid, dead, and uninspectable container entries while preserving normal container listing behavior. - How: validate each container record before inspect, skip dead state/status rows, skip failed inspect payloads, and fall back to the list name when inspect omits Name.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
🧹 PR Test Plugin Cleaned UpThe test plugin and associated files for this PR have been removed from the preview environment. 🤖 This comment is automatically generated when a PR is closed. |
2 participants
Summary
7.2.dead, and uninspectable Docker container entries out of the WebGUI Docker list.Why
Docker engine/containerd shutdown races can leave orphaned dead container metadata. Those entries can appear as ghost rows in
docker ps -aand in the WebGUI, but users cannot act on them from the UI.References
Test plan
php -l emhttp/plugins/dynamix.docker.manager/include/DockerClient.phpgit diff --check origin/7.2...HEAD