Skip to content

fix: allow mover empty action without pools on 7.2#2615

Merged
limetech merged 1 commit into
7.2from
codex/7.2-mover-empty-no-pool
Apr 14, 2026
Merged

fix: allow mover empty action without pools on 7.2#2615
limetech merged 1 commit into
7.2from
codex/7.2-mover-empty-no-pool

Conversation

@elibosley
Copy link
Copy Markdown
Member

Summary

  • backport the mover empty-action fix to 7.2
  • keep mover controls available when user shares are enabled but no pool devices exist
  • label the no-pool action as Empty / Empty now so the UI reflects the supported operation
  • preserve disabled behavior while parity, mover, or BTRFS operations are active

Root cause

The UI treated missing pool devices as a reason to disable or hide mover controls entirely. That blocked the array-disk empty workflow even though emptying an array disk can run without a configured pool.

Source

Cherry-picked from fd5251ad4fab628c5ea0800642d6b312da25ade9.

Verification

  • php -l emhttp/plugins/dynamix/MoverSettings.page
  • php -l emhttp/plugins/dynamix/ArrayOperation.page

- Purpose: backport the no-pool mover empty fix to the 7.2 branch.\n- Before: the UI disabled or hid mover controls when no cache/pool devices existed, even though the empty-array-disk action can still run without a pool assignment.\n- Why: users could not invoke mover to empty an array disk on systems with no configured pool.\n- What: keep mover controls available for the empty action when user shares are enabled and no pool devices exist.\n- How: update the scheduler button text/state and add matching Array Operation button handling for no-pool systems while preserving disabled states during parity, mover, and BTRFS operations.\n- Source: cherry-picked from fd5251a.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6207a703-84ce-47a3-834f-b4087da65da6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/7.2-mover-empty-no-pool

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.04.14.1712
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2615/webgui-pr-2615.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/ArrayOperation.page
emhttp/plugins/dynamix/MoverSettings.page

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2615, or run:

plugin remove webgui-pr-2615

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@elibosley elibosley marked this pull request as ready for review April 14, 2026 17:18
@limetech limetech merged commit 9294349 into 7.2 Apr 14, 2026
2 checks passed
@limetech limetech deleted the codex/7.2-mover-empty-no-pool branch April 14, 2026 18:05
@github-actions
Copy link
Copy Markdown

🧹 PR Test Plugin Cleaned Up

The test plugin and associated files for this PR have been removed from the preview environment.


🤖 This comment is automatically generated when a PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants