fix(help): correct FTP server default text#2633
Conversation
Purpose of the change: - Update the FTP settings help text to describe the current default server state. Previous behavior: - The help text said the FTP server is enabled by default. Why that was a problem: - The default inetd FTP entry is commented out, so the help text contradicted the default disabled state. New behavior: - The FTP help text now says the FTP server is disabled by default. How it works: - Changes only the localized English help text for :ftp_server_help:.
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single-line localization update modifies the FTP server help text to state that the daemon is disabled by default and clarifies that the setting controls enable/disable functionality. Help Text Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
:ftp_server_help:.Validation
rg -n "By default the FTP server is disabled" emhttp/languages/en_US/helptext.txtroot@unraid.localread-only:/etc/inetd.confhas the FTPvsftpdline commented and port 21 has no listener.Summary by CodeRabbit