Skip to content

feat: Add unsloth Dockerfile and gptoss 20b finetuning notebook for strix halo #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add unsloth Dockerfile and gptoss 20b finetuning notebook for strix halo #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
457994b
strixhalo/gptossnotebok
0xrushi Nov 13, 2025
5d03dcf
cleanup
0xrushi Nov 13, 2025
5b7ab8d
Remove depth option from git clone commands
0xrushi Nov 14, 2025
be60c00
Restore old dockerfile
0xrushi Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions Dockerfile_Strix_Halo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
FROM rocm/pytorch:rocm6.4.4_ubuntu24.04_py3.12_pytorch_release_2.7.1

# Create a new user with sudo privileges (passwordless)
RUN apt-get update && apt-get install -y sudo && \
useradd -m -s /bin/bash user && \
usermod -aG sudo user && \
echo "user ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers && \
apt-get clean && rm -rf /var/lib/apt/lists/*
Comment on lines +4 to +8
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Granting the user passwordless sudo for all commands (NOPASSWD:ALL) poses a significant security risk, as it provides unrestricted root access without any authentication. While this may be convenient for a development environment, it is a dangerous practice. Consider running as the root user and only switching to a non-root user at the end of the Dockerfile, or grant more specific, limited sudo permissions if root access is required for certain operations.

Copy link
Collaborator

@rolandtannous rolandtannous Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should definitely prevent passwordless sudo for all commands.


WORKDIR /opt/src

# bitsandbytes (ROCm)
RUN git clone -b rocm_enabled_multi_backend https://github.com/ROCm/bitsandbytes.git
WORKDIR /opt/src/bitsandbytes
RUN cmake -S . -DGPU_TARGETS="gfx1151" -DBNB_ROCM_ARCH="gfx1151" -DCOMPUTE_BACKEND=hip && \
make -j && \
python -m pip install --no-cache-dir .

# Python deps
RUN python -m pip install --no-cache-dir \
'datasets>=3.4.1' \
'sentencepiece>=0.2.0' \
tqdm psutil 'wheel>=0.42.0' \
'accelerate>=0.34.1' \
'peft>=0.7.1,!=0.11.0' \
einops packaging

# xformers (pinned)
WORKDIR /opt/src
RUN git clone https://github.com/ROCm/xformers.git
WORKDIR /opt/src/xformers
RUN git submodule update --init --recursive && \
git checkout 13c93f3 && \
PYTORCH_ROCM_ARCH=gfx1151 python setup.py install

ENV FLASH_ATTENTION_TRITON_AMD_ENABLE="TRUE"
WORKDIR /root
RUN git clone https://github.com/ROCm/flash-attention.git
RUN cd flash-attention && git checkout v2.7.4-cktile && python setup.py install

# Unsloth (install first), then Zoo
WORKDIR /opt/src
RUN git clone https://github.com/unslothai/unsloth.git

WORKDIR /opt/src/unsloth
RUN python -m pip install --no-cache-dir .
RUN python -m pip install --no-cache-dir jupyterlab ipywidgets ipykernel tqdm
RUN python -m pip install --no-cache-dir 'unsloth_zoo>=2025.5.7'

# Set default user and working directory
USER user
WORKDIR /home/user
CMD ["/bin/bash"]
Loading