Make minor fixes to the Docker testing environment#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm starting to write tests for
export.Exporterclasses, and made a few minor tweaks so that I could get the jobs to actually run in the Docker testing environment. The main functional change was to set the SOLRMARC_CONFIG_FILE for thetestandmanage-testservices indocker-compose.yml. Without that, SolrMarc will try to use the dev config file and use the wrong connection parameters for Solr.In addition to that, I made a quality-of-life change to make it easier to debug tests that use the testing environment. A
logsand amediadirectory are now mapped to adocker_datavolume for tests, like they are for the dev app.Note: After applying this change-set locally, you'll want to run
./init-dockerdata.sh testto force it to create the new volumes.