Use Property::new() in make_builder_fn!#33
Open
rogarb wants to merge 2 commits intountitaker:masterfrom
Open
Conversation
When using Property::new(name, value), the value is escaped before being stored in the raw_value field. It was not the case when using the direct instantiation pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current VcardBuilder implementation, builder functions are created
with the macro make_builder_fn!. This macro was instantiating Property
object directly, thus not using the Property::new() interface.
When using the Property::new(name, value) interface, the value is escaped
before being stored in the raw_value field. It was not the case when using
direct instantiation.