Skip to content

BridgeJS: Emit protocol array for-loop as a single CodeBlockItemSyntax #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krodak wants to merge 1 commit into from
+12 −10
Closed

BridgeJS: Emit protocol array for-loop as a single CodeBlockItemSyntax #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,15 +827,15 @@ struct StackCodegen {
accessor: String,
varPrefix: String
) -> [CodeBlockItemSyntax] {
var statements: [CodeBlockItemSyntax] = []
let elemVar = "__bjs_elem_\(varPrefix)"
statements.append("for \(raw: elemVar) in \(raw: accessor) {")
statements.append(
" _swift_js_push_i32((\(raw: elemVar) as! _BridgedSwiftProtocolExportable).bridgeJSLowerAsProtocolReturn())"
)
statements.append("}")
statements.append("_swift_js_push_i32(Int32(\(raw: accessor).count))")
return statements
return [
"""
for \(raw: elemVar) in \(raw: accessor) {
_swift_js_push_i32((\(raw: elemVar) as! _BridgedSwiftProtocolExportable).bridgeJSLowerAsProtocolReturn())
}
""",
"_swift_js_push_i32(Int32(\(raw: accessor).count))",
]
}

private func lowerDictionaryStatements(
Expand Down
6 changes: 4 additions & 2 deletions Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/Protocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,8 @@ public func _bjs_processDelegates() -> Void {
#if arch(wasm32)
let ret = processDelegates(_: [AnyMyViewControllerDelegate].bridgeJSStackPop())
for __bjs_elem_ret in ret {
_swift_js_push_i32((__bjs_elem_ret as! _BridgedSwiftProtocolExportable).bridgeJSLowerAsProtocolReturn())}
_swift_js_push_i32((__bjs_elem_ret as! _BridgedSwiftProtocolExportable).bridgeJSLowerAsProtocolReturn())
}
_swift_js_push_i32(Int32(ret.count))
#else
fatalError("Only available on WebAssembly")
Expand Down Expand Up @@ -955,7 +956,8 @@ public func _bjs_DelegateManager_delegates_get(_ _self: UnsafeMutableRawPointer)
#if arch(wasm32)
let ret = DelegateManager.bridgeJSLiftParameter(_self).delegates
for __bjs_elem_ret in ret {
_swift_js_push_i32((__bjs_elem_ret as! _BridgedSwiftProtocolExportable).bridgeJSLowerAsProtocolReturn())}
_swift_js_push_i32((__bjs_elem_ret as! _BridgedSwiftProtocolExportable).bridgeJSLowerAsProtocolReturn())
}
_swift_js_push_i32(Int32(ret.count))
#else
fatalError("Only available on WebAssembly")
Expand Down