[CC-3237] Add php 8.5 to composer.json#224
Merged
Ryouzanpaku merged 5 commits intomainfrom Feb 19, 2026
Merged
Conversation
Ryouzanpaku
force-pushed
the
CC-3237/php_8_5_support
branch
from
8bc304d to
3379ebc
Compare
Ryouzanpaku
force-pushed
the
CC-3237/php_8_5_support
branch
from
3379ebc to
ed9eed4
Compare
- `curl_close` - `\ReflectionMethod::setAccessible`
Ryouzanpaku
force-pushed
the
CC-3237/php_8_5_support
branch
from
94fb9ac to
524ab31
Compare
Ryouzanpaku
force-pushed
the
CC-3237/php_8_5_support
branch
from
524ab31 to
2d76d2b
Compare
Ryouzanpaku
commented
Feb 18, 2026
| */ | ||
| public function close(): void | ||
| { | ||
| curl_close($this->request); |
Contributor
Author
There was a problem hiding this comment.
curl_close got removed because it is deprecated and did not do anything from php 8.0 onwards.
NiushaGhanbari
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer and PHPUnit configuration:
composer.jsonto require PHP 8.1+ and PHPUnit 9.6+Cleanup deprecations
phpunit.xmlfor stricter test enforcement.curl_closeTest reporting