Skip to content

country/code_fetcher.go: prevent records with smaller assignment priority from overwriting those with higher priority#87

Merged
xgoffin merged 3 commits intomasterfrom
xg/assignment
Apr 30, 2026
Merged

country/code_fetcher.go: prevent records with smaller assignment priority from overwriting those with higher priority#87
xgoffin merged 3 commits intomasterfrom
xg/assignment

Conversation

@xgoffin
Copy link
Copy Markdown
Contributor

@xgoffin xgoffin commented Apr 30, 2026

What does this PR do?

We have two United Kingdoms:

                {
                        Name:        "United Kingdom",
                        Alpha2:      "GB",
                        Alpha3:      "GBR",
                        Numeric:     826,
                        DialingCode: "+44",
                        Assignment:  OfficiallyAssigned,
                },

		{
			Name:           "United Kingdom",
			Alpha2:         "UK",
			Alpha3:         "",
			Numeric:        -1,
			DialingCode:    "+44",
			Assignment:     ExceptionallyReserved,
			AlternateNames: []string{"Northern Ireland"},
		},

Latter overloads the former in Name

Fixes #

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

Additional Notes

…rity from overwriting those with higher priority
@xgoffin xgoffin self-assigned this Apr 30, 2026
@xgoffin xgoffin requested a review from a team as a code owner April 30, 2026 09:30
@xgoffin xgoffin requested review from karitham and pauloestrella1994 and removed request for a team April 30, 2026 09:30
Comment thread country/code_fetcher.go Outdated
@xgoffin xgoffin merged commit 48dc9eb into master Apr 30, 2026
5 checks passed
@xgoffin xgoffin deleted the xg/assignment branch April 30, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants