-
Notifications
You must be signed in to change notification settings - Fork 1
Update all dependencies, Node.js min to v20, replace jest with node:test
#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Pin node and yarn versions using volta - Remove Node v18 from the Test suite, adding Node v24
- Moves to the maintained project, while fixing a security vulnerability.
- Fixes some security vulnerabilities in dependencies of `release-it`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the repository's testing and tooling infrastructure by migrating from Jest to Node.js's native node:test framework, updating ESLint to v9 with a new flat config format, and bumping the minimum Node.js version from v14 to v20. The changes also include dependency updates to address security vulnerabilities and improvements to the CI/CD workflows.
Key changes:
- Complete migration from Jest to
node:testwith updated assertions usingnode:assert - ESLint upgraded to v9 with new flat config format (
eslint.config.mjs) - Minimum Node.js version raised to v20, with CI matrix updated to test v20, v22, and v24
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utils.test.js | Migrated Jest tests to node:test with appropriate assertions |
| test/index.test.js | Converted Jest mocks and assertions to node:test equivalents |
| src/index.js | Alphabetically reordered parameters in addHook method |
| package.json | Updated all dependencies, removed Jest config, added devEngines, updated Node requirement to >=20 |
| eslint.config.mjs | New ESLint v9 flat config replacing .eslintrc.yml |
| .eslintrc.yml | Removed legacy ESLint configuration |
| README.md | Formatting improvements to code examples and documentation |
| .github/workflows/release.yaml | Updated to use newer action versions and improved npm/git configuration |
| .github/workflows/ci.yaml | Updated Node.js matrix and action versions, now runs coverage tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Update `eslint@9.32.0` - Update `eslint-config-uphold@6.7.1` - Update `prettier@3.6.2`
9819aa9 to
b2d972b
Compare
Description
eslint-config-upholdandprettierto the latest versions.jestwithnode:test.pre-commitwith@fastify/pre-commit.release-itand the release workflow.README.@uphold/github-changelog-generator.devEnginestopackage.json.