Only report coverage for src and apps folders#14
Conversation
| "*/**/*.js", | ||
| "!config/**/*", | ||
| "!coverage/**/*", | ||
| "!migrations/**/*", |
There was a problem hiding this comment.
We also have migrations under database/migrations/. We should probably include that one as well.
Alternatively, if we're seeing this list grow too much, should we switch the logic and apply a whitelist instead? Do we care for more directories other than apps and src?
There was a problem hiding this comment.
I'm not against whitelisting src and apps, seems more generic.
Shall we change it?
There was a problem hiding this comment.
test,bin?
You want coverage for test?
And bin usually is scripts, which I think we don't test (currently it's only searching for *.js files).
There was a problem hiding this comment.
We're currently blacklisting test, so I don't think we'd want to start whitelisting it.
About bin, I'm on the fence. We can add it, as we may indeed have JavaScript files there, but I was under the impression that most of the times that directory was for CLI commands that might be tricky to test with jest and that defer all testable logic to a separate module in src anyway.
ricardobcl
force-pushed
the
enhancement/ignore-migrations-folder-for-tests
branch
from
dbc5e38 to
ae57f42
Compare
ricardobcl
changed the title
src and apps folder
ricardobcl
changed the title
src and apps foldersrc and apps folders
rplopes
left a comment
rplopes
left a comment
There was a problem hiding this comment.
As per our discussion, LGTM for switching from blacklisting to whitelisting. This should also help in reducing the number of customisations to this setting in our repos, which is nice 👍
3 participants
No description provided.