Fix lint-staged not working correctly #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogotorres97
force-pushed
the
fix-lint-staged-readme
branch
from
6b338d7 to
0681a72
Compare
diogotorres97
requested changes
Feb 22, 2022
satazor
force-pushed
the
fix-lint-staged-readme
branch
from
0681a72 to
76cf4d3
Compare
Americas
reviewed
Feb 22, 2022
Contributor
|
Is this still a breaking change? |
satazor
force-pushed
the
fix-lint-staged-readme
branch
from
76cf4d3 to
7ef196c
Compare
satazor
force-pushed
the
fix-lint-staged-readme
branch
from
7ef196c to
66d0e97
Compare
Contributor
Author
|
Hey folks! I've updated the PR to be more inline with what we had. I think we can release this as a patch release. Consumers will just need to update the package.json, which was wrong anyway as However, if we merge #55 we will release a major anyway (minor actually because we are still < v1). |
Contributor
Author
|
Once you got the time @diogotorres97 give it a test and review! 🙏 |
satazor
changed the title
Americas
approved these changes
Feb 27, 2022
diogotorres97
approved these changes
Mar 2, 2022
Contributor
diogotorres97
left a comment
diogotorres97
left a comment
There was a problem hiding this comment.
LGTM. It seems to be working 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My manually testing done in #12 was wrong for some reason. This is the correct setup for the package.json.
pre-commitonly runs scripts declared inscripts@ package.json.