Skip to content

Improve changelog generation#8

Merged
Americas merged 2 commits intomasterfrom
enhancement/improve-changelog-generation
Aug 14, 2018
Merged

Improve changelog generation#8
Americas merged 2 commits intomasterfrom
enhancement/improve-changelog-generation

Conversation

@rplopes
Copy link
Copy Markdown
Contributor

@rplopes rplopes commented Aug 14, 2018

Drop the redundant v for release names. Keep it for release tags, since that's how they're automatically generated when calling npm version.

@rplopes rplopes added the enhancement New feature or request label Aug 14, 2018
@rplopes rplopes self-assigned this Aug 14, 2018
@rplopes rplopes requested a review from Americas August 14, 2018 15:40
Comment thread CHANGELOG.md Outdated
# Changelog

## [v0.1.0](https://github.com/uphold/uphold-scripts/releases/tag/v0.1.0) (2018-07-31)
## [0.1.0](https://github.com/uphold/uphold-scripts/releases/tag/0.1.0) (2018-08-13)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running it again, this is not correct.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@rplopes rplopes force-pushed the enhancement/improve-changelog-generation branch from 0e35f75 to f62b2ee Compare August 14, 2018 15:53
Copy link
Copy Markdown
Contributor

@Americas Americas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Americas Americas merged commit 94c2641 into master Aug 14, 2018
@Americas Americas deleted the enhancement/improve-changelog-generation branch August 14, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants