Conversation
Closed
Rexogamer
reviewed
Mar 31, 2025
| SidebarButton, | ||
| SidebarButtonContent, | ||
| SidebarButtonTitle, | ||
| SidebarButtonContent, SidebarButtonIcon, |
Member
There was a problem hiding this comment.
you'll probably want to run Prettier
Author
There was a problem hiding this comment.
I wanna kill webstorm for that
Author
|
crap i forgot to exclude submodules on the fmt command hold on |
amycatgirl
force-pushed
the
fix/theme-colours
branch
from
9e5317b to
cbe0c6b
Compare
turns out that the fmt and fmt:check scripts were broken, now they aren't ok i fixed the previous commit, i am dumb
Author
|
OK submodules now shouldn't error on CI |
Member
|
These could be changed to be lighter (along with first one maybe having a background all the time?), otherwise ACK. |
Member
Screencast.From.2025-04-01.21-12-07.webm |
retcinder
approved these changes
Apr 2, 2025
Member
retcinder
left a comment
retcinder
left a comment
There was a problem hiding this comment.
ACK, my other complaint doesn't really need to be resolved (the lighter background makes dark colours for channel invite/settings icon not bad)
github-project-automation
Bot
moved this from Untriaged
to Ready to merge
in Pull Request Tracker
Rexogamer
approved these changes
Apr 3, 2025
github-project-automation
Bot
moved this from Untriaged
to Merged
in Pull Request Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some icons, mainly the ones present on the space sidebar and the home page, are not themed properly and are missing a
fillattribute, which causes contrasts issues as the default colour is black. And as we all know, black on dark colours don't bode well on dark mode themes.