Skip to content

CLOUD-4245 improve-redis-search-docs#651

Merged
mdogan merged 7 commits into
mainfrom
CLOUD-4245
May 12, 2026
Merged

CLOUD-4245 improve-redis-search-docs#651
mdogan merged 7 commits into
mainfrom
CLOUD-4245

Conversation

@up-ilter
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds and expands Upstash Redis Search documentation to make common usage patterns and failure modes easier to understand, with new reference-style pages and clearer response/parameter explanations.

Changes:

  • Added new Command Reference and Troubleshooting pages for Redis Search.
  • Expanded existing docs with response-format sections (query + aggregations) and added schema FAST/field-type reference material.
  • Updated navigation to include the new pages.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
redis/search/troubleshooting.mdx New troubleshooting guide covering common index/query/aggregation/schema errors.
redis/search/command-reference.mdx New command reference for SEARCH.* commands, parameters, and return formats.
redis/search/schema-definition.mdx Adds field type reference table and FAST field explanation.
redis/search/querying.mdx Documents query response format and adds LIMIT/OFFSET parameter table.
redis/search/query-operators/field-operators/overview.mdx Adds quick-reference table for field operators.
redis/search/aggregations.mdx Documents aggregation response format and adds FAST-field note.
redis/search/aggregation-operators/metric-aggregations/overview.mdx Clarifies metric operator input format and common error messages.
redis/search/aggregation-operators/bucket-aggregations/overview.mdx Clarifies bucket operator input format and nested $aggs behavior.
redis/search/index-management.mdx Clarifies what SEARCH.WAITINDEXING waits for and when to use it.
redis/search/counting.mdx Clarifies that SEARCH.COUNT returns a single integer.
docs.json Adds the new Search docs pages to the sidebar/navigation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread redis/search/troubleshooting.mdx Outdated
Comment thread redis/search/command-reference.mdx Outdated
Comment thread redis/search/command-reference.mdx Outdated
Copy link
Copy Markdown
Contributor Author

@up-ilter up-ilter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick Review

Summary

Comprehensive documentation enhancement for Redis Search that adds two new guide pages (Command Reference and Troubleshooting) and enriches existing guides with request/response format examples, reference tables, and practical code samples across TypeScript, Python, and Redis CLI.

Key changes:

  • Added new Command Reference page documenting all SEARCH.* commands (SEARCH.CREATE, SEARCH.QUERY, SEARCH.AGGREGATE, SEARCH.COUNT, alias commands, etc.) with syntax, parameters, and examples
  • Added new Troubleshooting page covering common errors and fixes (index creation, query syntax, aggregation field requirements, schema issues, Upstash vs RediSearch differences)
  • Enhanced aggregation documentation with Response Format section showing result structures for TypeScript, Python, and Redis CLI with practical examples
  • Added Input Format sections to bucket and metric aggregation overviews with JSON examples for each operator type
  • Created Field Type Reference table documenting all field types (TEXT, KEYWORD, F64, DATE, BOOL, FACET) with FAST support and supported operators
  • Enhanced query documentation with Response Format examples and LIMIT/OFFSET parameter reference table
  • Added Field Operators Quick Reference table and expanded SEARCH.WAITINDEXING documentation with guidance on optimal usage patterns

Verdict

Metric Value
Risk Score 35/100
Recommendation request changes
Findings 13 accepted

Found 13 issue(s) across all reviewers. 5 blocking issue(s) require attention before merge. Overall risk score: 35/100. Changes are requested before merging.

Blockers

  • 🟠 HIGH Bearer Token detected in added code (redis/search/command-reference.mdx:39)
  • 🟠 HIGH Bearer Token detected in added code (redis/search/command-reference.mdx:144)
  • 🟠 HIGH Bearer Token detected in added code (redis/search/command-reference.mdx:171)
  • 🟠 HIGH Bearer Token detected in added code (redis/search/command-reference.mdx:208)
  • 🟠 HIGH Bearer Token detected in added code (redis/search/command-reference.mdx:261)

Suggested Commits

  • fix: bearer token detected in added code
  • fix: bearer token detected in added code
  • fix: bearer token detected in added code
  • fix: bearer token detected in added code
  • fix: bearer token detected in added code

Generated by Nitpick

Comment thread redis/search/command-reference.mdx Outdated
Comment thread redis/search/command-reference.mdx Outdated
Comment thread redis/search/command-reference.mdx Outdated
Comment thread redis/search/command-reference.mdx Outdated
Comment thread redis/search/command-reference.mdx Outdated
Comment thread redis/search/aggregation-operators/bucket-aggregations/overview.mdx Outdated
Comment thread redis/search/aggregations.mdx
Comment thread redis/search/querying.mdx
Comment thread redis/search/aggregations.mdx
Comment thread redis/search/aggregation-operators/bucket-aggregations/overview.mdx
Comment thread redis/search/aggregation-operators/metric-aggregations/overview.mdx Outdated
Comment thread redis/search/aggregation-operators/metric-aggregations/overview.mdx Outdated
Comment thread redis/search/aggregation-operators/metric-aggregations/overview.mdx Outdated
Comment thread redis/search/aggregations.mdx Outdated
Comment thread redis/search/aggregations.mdx Outdated
Comment thread redis/search/aggregations.mdx Outdated
Comment thread redis/search/aggregations.mdx Outdated
Comment thread redis/search/aggregations.mdx Outdated
Comment thread redis/search/counting.mdx Outdated
Comment thread redis/search/index-management.mdx Outdated
@mdogan mdogan self-requested a review March 30, 2026 08:40
@mdogan mdogan marked this pull request as draft March 30, 2026 08:42
@mdogan mdogan removed their request for review April 29, 2026 14:33
@mdumandag mdumandag marked this pull request as ready for review May 12, 2026 11:47
@mdogan mdogan merged commit fac2348 into main May 12, 2026
2 checks passed
@mdogan mdogan deleted the CLOUD-4245 branch May 12, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants