Add Optional base_url Parameter to Clients #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
reviewed
Dec 24, 2024
qstash/client.py
Outdated
| http = HttpClient( | ||
| token, | ||
| retry, | ||
| base_url=(base_url or "https://qstash.upstash.io"), |
Collaborator
There was a problem hiding this comment.
no need for another default here
qstash/asyncio/client.py
Outdated
| http = AsyncHttpClient( | ||
| token, | ||
| retry, | ||
| base_url=(base_url or "https://qstash.upstash.io"), |
Collaborator
There was a problem hiding this comment.
no need for another default here
qstash/asyncio/http.py
Outdated
| self, | ||
| token: str, | ||
| retry: Optional[Union[Literal[False], RetryConfig]], | ||
| base_url: str, |
Collaborator
There was a problem hiding this comment.
can be optional with default value None
qstash/http.py
Outdated
| self, | ||
| token: str, | ||
| retry: Optional[Union[Literal[False], RetryConfig]], | ||
| base_url: str, |
Collaborator
There was a problem hiding this comment.
can be optional with default value none
mdumandag
reviewed
Dec 24, 2024
qstash/asyncio/http.py
Outdated
| timeout=DEFAULT_TIMEOUT, | ||
| ) | ||
|
|
||
| self._base_url = base_url |
Collaborator
There was a problem hiding this comment.
you can make this base_url.rstrip("/") if base_url else BASE_URL to get rid of tri-operand or in every call to request, and restore the rstrip behavior
CahidArda
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional
base_urlparameter to QStash clients. This can be used to change the url of the QStash client for development/testing purposes.