fix(init): ignore unknown data keys in AI config stream#40
Merged
miguelsanchez-upsun merged 2 commits intomainfrom Apr 9, 2026
Merged
fix(init): ignore unknown data keys in AI config stream#40miguelsanchez-upsun merged 2 commits intomainfrom
miguelsanchez-upsun merged 2 commits intomainfrom
Conversation
The NDJSON stream handler errored on unrecognized data keys, which broke the CLI when the API added a new "topology" key. Ignore unknown keys so future API additions don't break older CLI versions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the upsun init AI NDJSON stream processing to be forward-compatible with new API “data” keys (e.g., topology) by no longer erroring on unrecognized keys.
Changes:
- Stop treating unknown
datakeys in the AI config stream as fatal errors. - Continue unmarshalling the expected
outputpayload while ignoring everything else.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
miguelsanchez-upsun
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upsun initerrored on unrecognized data keys, which broke the CLI when the API added a newtopologykeyGenerated with Claude Code