fix(tunnel:open): cast remote port to int#91
Merged
Conversation
The relationship metadata returned by the API delivers `port` as a string. Tunnel::__construct types $remotePort as int, so tunnel:open crashed with a TypeError when constructing the Tunnel object. Cast $service['port'] to int at the call site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a tunnel:open crash by ensuring relationship metadata ports are passed to Tunnel with the expected integer type.
Changes:
- Casts the remote service port to
intwhen creating a tunnel. - Adds a regression test covering string-valued relationship ports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
legacy/src/Service/TunnelManager.php |
Casts the service port value before constructing Tunnel. |
legacy/tests/Service/TunnelManagerTest.php |
Adds coverage for creating a tunnel from API-style string port metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upsun tunnel:opencrashes with a fatalTypeErrorbefore the tunnel is created:The
portvalue in the relationship metadata returned by the API arrives as a string.Tunnel::__constructtypes$remotePortasint, so constructing theTunnelblows up atTunnelManager.php:54.Fix: cast
$service['port']tointat the call site. Added a regression test that reproduces the exact failure from #72 without the fix and passes with it.Closes #72.
Note: PR #89 fixed the sibling
$localPortcast fortunnel:single --porton Windows, but didn't touch the$remotePortpath used bytunnel:open.🤖 Generated with Claude Code