Adds ability to specify wordbank path and max_index with CLI args#3
Merged
Adds ability to specify wordbank path and max_index with CLI args#3
path and max_index with CLI args#3Conversation
Still needs the ability to tweak the `max_index` value, but this should do the trick for the file IO side of things.
Adds the ability to set the maximum index for the random word generator, allowing it to only look at the first `x` number of lines where `x` is a valid `u32` value.
Since it is included into the binary during compilation, the file was truncated to the first 500 lines, reducing bloat from 40KB to 4KB.
Updated repo URL in the README file, and incremented the minor version as this is a pretty big change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
-l(--load) and-i(--max_index), which denote a file path for a wordbank, and the number of lines in the file.Issue ticket number and link
#2 - Should notify user if wordbank not found in the local directory
Checklist before requesting a review