Remote Scry#305
Merged
belisarius222 merged 10 commits intonext/kelvin/413from Apr 25, 2023
Merged
Conversation
61 tasks
|
Make sure to incorporate the commits from this PR here: urbit/urbit#5806 |
joemfb
reviewed
Apr 21, 2023
| u3_ames* sam_u = (u3_ames*)car_u; | ||
|
|
||
| return u3i_list( | ||
| u3_pier_mase("scry-cache", u3i_word(u3h_mark(sam_u->fin_s.sac_p))), |
Collaborator
There was a problem hiding this comment.
This leaks memory -- calls to *_mark() functions must be followed by a call to u3a_sweep(), and that requires that all roots are properly recorded and marked. You should be able to use u3h_count() and u3h_discount() to do a granular measurement (effectively a partial mark/sweep collection).
Collaborator
There was a problem hiding this comment.
Also, this should be duplicated as a printf in _ames_io_info().
first pass, to match remote scry interface on the arvo side
joemfb
added a commit
that referenced
this pull request
Apr 25, 2023
and makes a small fix intended for #305.
pkova
added a commit
that referenced
this pull request
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #303