Conversation
pkova
added a commit
that referenced
this pull request
May 12, 2025
I removed the ivory pill from the serf in #750, but I missed this code path in _mars_do_boot. This code only ever runs if the process has been killed during initial boot and we have to replay. The older ivory pill being installed breaks the structural sharing for jet registrations, causing ships that crash during boot to perform extremely poorly until they get melded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#749 introduced an issue where CI on urbit/urbit suddenly became dog slow. This was eventually traced down to the fact that jets registered by the ivory pill in the serf were extremely slow to check for because of missing structural sharing. The only reason to install the ivory pill in the serf is to have stacktraces when arvo fails to compile in CI. Removing that feature is acceptable to keep things moving for now.