Conversation
pkova
added a commit
that referenced
this pull request
Dec 20, 2024
My changing of the semantics of the request bitset in #754 messed with the congestion control. This PR restores the outstanding fragments in flight tracking by using a counter, getting 30 mb/s with this for pokes on a M2 max locally.
pkova
added a commit
that referenced
this pull request
Jan 11, 2025
I was messing with static udp receive buffer allocation in #754. We decided to revert it in #755, but I missed one `c3_free` in the stun request packet codepath, causing a fairly significant memory leak when `vere-v3.2` was deployed on a galaxy. This restores the old free and plugs the leak. This bug was unreleased and only appeared on `edge` and specifically only on galaxies, it showed up now because I updated the custom binary on `~fen` for unrelated reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does all kinds of stuff. The main ones are the following:
The udp receive buffer for ames and mesa is now statically allocated. The sending buffer for ames is also statically allocated, so now we use
uv_udp_try_sendinstead ofuv_udp_sendin ames.The meaning of the bitset in the mesa pending request structure is different. It used to answer the question whether we have an outstanding request for a particular fragment, whereas now it answers the question "do we have this fragment?".
The misordered queue for mesa is now arbitrarily large instead of 8 fragments long. This means that we can receive fragments in any order.