Conversation
joemfb
reviewed
Feb 12, 2025
| c3_i rec_i = 2 * 1024 * 1024; | ||
| uv_recv_buffer_size((uv_handle_t*)&u3_Host.wax_u, &rec_i); | ||
|
|
||
| uv_send_buffer_size((uv_handle_t*)&u3_Host.wax_u, &rec_i); |
Collaborator
There was a problem hiding this comment.
It seems like we should read the buffer sizes (setting rec_i = 0) before setting them, to make sure we're not shrinking them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several big improvements to the mesa driver:
mallocandfreecalls all over the place anymore. The allocations have been grouped into lifetimes each with their own memory arena.As a result we go from around 15 megabytes/second to 190 megabytes/second bandwidth for localhost peeking on my macbook M2. Corresponding speeds between two terrible 1 cpu 2gb VM:s situated on the other sides of the Atlantic go from around 2 megabytes/s to 18 megabytes/s.
There is still room to optimize the speed of directed messaging but this is certainly good enough for an initial release. The main thing that's somewhat wonky still is the congestion control.