Conversation
This handles indirect routes correctly. This commit also refactors _mesa_send_modal to remove some unnecessary allocations.
This happens in ames.c, "unified" driver.
Before changing this consider the edge case where a request completes while a peek resend is pending in the libuv send queue. The arena for the request gets freed, corrupting the outstanding peek packet.
Adds the jet for `++run` gate in urwasm: https://github.com/Quodss/urwasm. Arvo side: urbit/urbit#7095 Depends on the wasm3 fork: https://github.com/Quodss/wasm3/tree/urwasm. TODO: - [x] catch traps to return error values instead of `bail: fail` to enable catching Wasm errors in Hoon - [x] fuzz testing
Jet for `++sew` gate. Makes non-jetted urwasm tests 15 times faster. Note: I set `bail:fail` on non-atomic `a` for the same reason it `fail`s in `++can` jet: in Hoon this argument gets passed to `++lsh` and `++rsh` which take `+$bite`, which can be a cell. I fail the jet on other non-atomic arguments just in case. I also don't want to bother with the case of indirect `b` and/or `c` so I punt on them being indirect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.