Skip to content

http: only check cache on GET requests#806

Merged
pkova merged 1 commit intodevelopfrom
wh/http-cache-only-get
Apr 28, 2025
Merged

http: only check cache on GET requests#806
pkova merged 1 commit intodevelopfrom
wh/http-cache-only-get

Conversation

@will-hanlen
Copy link
Copy Markdown
Contributor

@will-hanlen will-hanlen commented Apr 23, 2025

fixes a bug where a POST request to /foo/bar would return the cached response for a GET at /foo/bar

@will-hanlen will-hanlen requested a review from a team as a code owner April 23, 2025 19:50
joemfb
joemfb approved these changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

@pkova pkova merged commit 2388d3a into develop Apr 28, 2025
2 checks passed
@pkova pkova deleted the wh/http-cache-only-get branch April 28, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemfb joemfb joemfb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@will-hanlen @joemfb @pkova