pier: initialize drivers after double boot protection#847
Merged
Conversation
The original double boot protection code was written such that it assumed to be executing synchronously before any events get processed. This assumption proved to be incorrect since we were initializing the drivers before executing the ames /boot scry. It is somewhat unclear whether this mattered in practice. We discovered this by investigating a ship that was peculiarly slow to to boot, but the root cause for the slowness was the sponsoring galaxy having trouble. We were also previously running the double boot protection check when doing the -X scry which is certainly unnecessary.
See the parent commit for context. While the solution implemented in the parent commit works, it is nasty and fragile because it relies on a halfway initialized u3_pier. This refactors the solution to use the same mechanisms as the %wyrd version negotiation, happening before _pier_work_init instead of in the middle of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original double boot protection code was written such that it assumed to be executing synchronously before any events get processed. This assumption proved to be incorrect since we were initializing the drivers before executing the ames /boot scry.
It is somewhat unclear whether this mattered in practice. We discovered this by investigating a ship that was peculiarly slow to to boot, but the root cause for the slowness was the sponsoring galaxy having trouble.
We were also previously running the double boot protection check when doing the -X scry which is certainly unnecessary.