Conversation
All ships on `edge` have been experiencing mysterious crashes in the urth process ever since we merged `next/kelvin/409` to `develop`. It took us two weeks to run this down, but the issue seems to be twofold: 1. We were leaking all effects in urth, causing a surprisingly slow leak on all but the most busy ships. This PR fixes the leak, 2. Unifying equality on the home road was enabled in `vere-v3.5`. `~dozreg-toplud` noticed that unifying equality is unsafe in the presence of uncounted references, and it seems likely that some change in `vere-v4.0` caused this pattern to occur in urth. This problem was mostly showing up as `palloc: page out of heap` or other allocator errors caused by the use-after-free. We will most likely disable the unifying equality on the home road later (at least for urth).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All ships on
edgehave been experiencing mysterious crashes in the urth process ever since we mergednext/kelvin/409todevelop. It took us two weeks to run this down, but the issue seems to be twofold:We were leaking all effects in urth, causing a surprisingly slow leak on all but the most busy ships. This PR fixes the leak.
Unifying equality on the home road was enabled in
vere-v3.5.~dozreg-topludnoticed that unifying equality is unsafe in the presence of uncounted references, and it seems likely that some change invere-v4.0caused this pattern to occur in urth. This problem was mostly showing up aspalloc: page out of heapor other allocator errors caused by the use-after-free. We will most likely disable the unifying equality on the home road later (at least for urth).