fix(onnx): use explicit max_width in SpanMLP.view() for ONNX export#318
Merged
Ingvarstep merged 1 commit intourchade:mainfrom Jan 27, 2026
Merged
Conversation
The SpanMLP class used an inferred dimension (-1) in the view() call, which causes ONNX export to fail with a reshape size mismatch error. When exporting to ONNX with dynamic shapes, PyTorch's ONNX exporter cannot reliably infer the -1 dimension, resulting in malformed reshape dimensions like [1, 128, 12, 512] for an input of shape [1, 128, 512]. This fix: 1. Stores max_width as an instance variable 2. Uses self.max_width explicitly in view() instead of -1 This makes SpanMLP consistent with other span representation classes (SpanMarker, SpanMarkerV0, SpanMarkerV1) which already use explicit max_width in their view() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ONNX export failure for models using
SpanMLPspan representation.The
SpanMLPclass used an inferred dimension (-1) in theview()call:This causes ONNX export to fail with a reshape size mismatch error because PyTorch's ONNX exporter cannot reliably infer the
-1dimension when using dynamic shapes.Error example:
Fix
max_widthas an instance variable in__init__self.max_widthexplicitly inview()instead of-1This makes
SpanMLPconsistent with other span representation classes (SpanMarker,SpanMarkerV0,SpanMarkerV1) which already use explicitmax_widthin theirview()calls.Testing