feat: add descriptions for bash and powershell autocompletion#2298
Open
gabelluardo wants to merge 1 commit intourfave:mainfrom
Open
feat: add descriptions for bash and powershell autocompletion#2298gabelluardo wants to merge 1 commit intourfave:mainfrom
gabelluardo wants to merge 1 commit intourfave:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR fixes a long standing issue with subshells, adding by default commands descriptions to all the supported shells.
bash_autocompleteandpowershell_autocompleteadded the ability to handle command descriptionsexample_test.gofixed output for the new behaviourhelp.goremoved the environment variable dependencyWhich issue(s) this PR fixes:
Fixes #1884
Special notes for your reviewer:
I'm a noob in bash so I think there is a big margin to improve that code.
It works, but suggestions are really welcome.
Testing
I used my own projects to test it with
bash,zshandfish, searching regressions.I'm not able to test the powershell implementation, but ideally should work
Release Notes