Skip to content

Batching#51

Merged
ninoseki merged 8 commits intomainfrom
batching
Jul 15, 2025
Merged

Batching#51
ninoseki merged 8 commits intomainfrom
batching

Conversation

@ninoseki
Copy link
Collaborator

Implement #34.

$ cat <<EOF > urls.txt
http://example.com
http://example.net
EOF

$ urlscan scan submit urls.txt http://example.org    
[
  {
    "key": "http://example.com",
    "result": {
      "message": "Submission successful",
      "uuid": "...",
      "result": "https://urlscan.io/result/...",
      "api": "https://urlscan.io/api/v1/result/.../",
      "visibility": "private",
      "options": {},
      "url": "http://example.com/",
      "country": "jp"
    }
  },
  {
    "key": "http://example.net",
    "result": {
      "message": "Submission successful",
      "uuid": "...",
      "result": "https://urlscan.io/result/.../",
      "api": "https://urlscan.io/api/v1/result/.../",
      "visibility": "private",
      "options": {},
      "url": "http://example.net/",
      "country": "jp"
    }
  },
  {
    "key": "http://example.org",
    "result": {
      "message": "Submission successful",
      "uuid": "...",
      "result": "https://urlscan.io/result/../",
      "api": "https://urlscan.io/api/v1/result/.../",
      "visibility": "private",
      "options": {},
      "url": "http://example.org/",
      "country": "jp"
    }
  }
]

@ninoseki ninoseki requested review from cdnsyseng, fw42 and heipei and removed request for fw42 July 14, 2025 02:41
@ninoseki
Copy link
Collaborator Author

ninoseki commented Jul 15, 2025

I named TotalTimeout because it only applies for the batch operation. submit command accepts both the batch scan and the single scan and TotalTimeout does not thing with the single case.(Timeout sounds like it applies to the both cases). But it looks like confusing.

So I split the command into scan (handles the single scan /as it is) and bulk-scan (handles the batch scan) and renamed TotalTimeout as Timeout as @cdnsyseng suggested.

@ninoseki ninoseki requested a review from cdnsyseng July 15, 2025 01:50
@ninoseki ninoseki merged commit 2863734 into main Jul 15, 2025
5 checks passed
@ninoseki ninoseki deleted the batching branch July 15, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants