Merged
Conversation
cdnsyseng
requested changes
Jul 15, 2025
docs/urlscan_scan_submit.md
Outdated
| -t, --tags stringArray User-defined tags to annotate this scan | ||
| -v, --visibility string One of public, unlisted, private | ||
| -w, --wait Wait for the scan(s) to finish | ||
| --with-both Download both a screenshot and a DOM (this flag overrides wait, with-screen and with-both flags to true) |
Contributor
There was a problem hiding this comment.
Suggested change
| --with-both Download both a screenshot and a DOM (this flag overrides wait, with-screen and with-both flags to true) | |
| -d, --download Download screenshot and DOM contents (overrides wait/dom/screenshot) |
docs/urlscan_scan_submit.md
Outdated
| -v, --visibility string One of public, unlisted, private | ||
| -w, --wait Wait for the scan(s) to finish | ||
| --with-both Download both a screenshot and a DOM (this flag overrides wait, with-screen and with-both flags to true) | ||
| --with-dom Download a DOM (this flag overrides wait flag to true) |
Contributor
There was a problem hiding this comment.
Suggested change
| --with-dom Download a DOM (this flag overrides wait flag to true) | |
| --dom Download only the DOM contents (overrides wait) |
docs/urlscan_scan_submit.md
Outdated
| -w, --wait Wait for the scan(s) to finish | ||
| --with-both Download both a screenshot and a DOM (this flag overrides wait, with-screen and with-both flags to true) | ||
| --with-dom Download a DOM (this flag overrides wait flag to true) | ||
| --with-screenshot Download a screenshot (this flag overrides wait flag to true) |
Contributor
There was a problem hiding this comment.
Suggested change
| --with-screenshot Download a screenshot (this flag overrides wait flag to true) | |
| --screenshot Download only the screenshot (overrides wait) |
Contributor
|
I think the flag names and descriptions could be improved. I didn't change other places in code in case we decide against the suggested changes. IMHO, there is no need to specify |
|
Didn't we agree in #39 that |
Collaborator
Author
But anyway I will split the functionality into |
cdnsyseng
requested changes
Jul 15, 2025
cdnsyseng
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add with options to do #39.
To be honest, I'm not sure whether this is the cleanest solution for #39 but it works like the following: