Adding note to readme for how to do manual run#19
Merged
SuperKogito merged 2 commits intomasterfrom Apr 4, 2020
Merged
Conversation
In the case that someone just wants to check a list of URLs, this should be shown in the README as a simple import of check_urls Signed-off-by: vsoch <vsochat@stanford.edu>
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 15 15
Lines 499 499
=======================================
Hits 365 365
Misses 134 134 Continue to review full report at Codecov.
|
Signed-off-by: vsoch <vsochat@stanford.edu>
Collaborator
Author
|
Also note that I accidentally added github.py (which shouldn't have been!) that has code that is ultimately represented in check.py. I can't believe we both missed this! Luckily it doesn't interact with any other code so it shouldn't be an issue for the previous releases. I still feel rather silly though :P |
SuperKogito
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the issue of wanting to just check a list of urls, and not interact with the client. This is possible, and I think we should expose how to do this in the README (the purpose of this PR).
Don't worry about time to review this @SuperKogito - it's a tiny detail just in the docs!
Signed-off-by: vsoch vsochat@stanford.edu