Commit d4e8e20
committed
Connect drawer: own the drawer so its gestures and the content's stay apart
The Material sheet could not keep the drawer's open/close gesture and the
content's scroll separate: while its settle animation runs it consumes any
touch's down for its own drag, so a scroll that started right after an
opening flick went to a sheet already at the top and died there, and a pull
through the content fought the animation frame by frame so only a fast
flick closed the drawer. Nothing in the sheet state can move, snap or
interrupt it from outside.
Replace the scaffold with the drawer on foundation's anchored draggable
(ConnectDrawerState): the same peek geometry, two-thirds expanded height,
fold marker, insets, tablet panel, handle and reset-on-close as before, with
the anchors computed from the layout, the peek and the measured sheet. The
drag handle keeps its own drag (and grabs a moving drawer), with the
expand/collapse actions for assistive tech. Under the content, one
nested-scroll connection routes each touch by ConnectSheetGesture's kind:
a drawer gesture interrupts any running animation, moves the drawer by raw
deltas, settles on release by the handle's own rule (125 dp/s, then 56 dp
from where it rested) and never scrolls the content; a content gesture
scrolls the content, stops at its top and never moves the drawer; the
content's own flings pass through untouched. The release rule is pure and
unit tested.
Verified on the S21: a scroll and a drag started right after an opening
flick, a slow pull to close from rest, during the opening animation and
right after a content fling, a flick to close, a long opening drag past the
top, a content fling that reaches the top, and opening and closing by the
handle; the content is at its top after every close.1 parent 67f76b8 commit d4e8e20
5 files changed
Lines changed: 337 additions & 90 deletions
File tree
- app/app/src
- main/java/com/bringyour/network/ui
- connect
- test/java/com/bringyour/network/ui/connect
Lines changed: 4 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
| |||
264 | 265 | | |
265 | 266 | | |
266 | 267 | | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
| 268 | + | |
271 | 269 | | |
272 | 270 | | |
273 | 271 | | |
| |||
1083 | 1081 | | |
1084 | 1082 | | |
1085 | 1083 | | |
1086 | | - | |
| 1084 | + | |
1087 | 1085 | | |
1088 | 1086 | | |
1089 | 1087 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| |||
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
39 | | - | |
| 38 | + | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
| |||
Lines changed: 113 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
0 commit comments