fix(ios): make UrApiService resolve the active api live, not once at init

The previous fix (.id(deviceManager.activeHostName) on the views that
instantiate LoginNavigationView) was unreliable in practice - after
applying a custom network in the login flow's NetworkServerSheet, the
app kept using the old network for wallet logins until restarted,
even though auth-code login picked up the change immediately.

Root cause: UrApiService captured a single SdkApi reference in its
initializer (private let api: SdkApi) and never re-read it. Forcing
SwiftUI to destroy/recreate the whole LoginNavigationView subtree via
.id() should have rebuilt this, but proved unreliable - likely because
the .sheet(...) that calls deviceManager.applyNetworkSpace(...) is
itself hosted by the view being torn down, so the id-triggered
recreation can race with or get coalesced away by the sheet's own
dismissal transaction.

This mirrors Android's actual fix: application.api is a *computed*
property ()
that's re-evaluated on every access, never cached. Ported the same
pattern to iOS:

- UrApiService.api is now a computed property backed by an
   closure, resolved on every call instead
  of once at init. Added  used at the top of every async
  function (mechanically, via ) which
  throws a clear error if no active api exists, instead of the old
  compile-time-guaranteed-non-optional but effectively stale reference.
- Kept the existing  for call sites that don't need
  to track network changes (e.g. MainView, once fully logged in).
- Added  for call sites that do.
- LoginNavigationView now builds urApiService as a computed property
  reading  live via a weak closure, instead of
  storing a UrApiService built once in init() (before deviceManager,
  an @EnvironmentObject, was even available).

The .id(deviceManager.activeHostName) modifiers added previously are
left in place as defense-in-depth (they still correctly reset
transient @State like navigation path and in-flight sheet state on
network switch) but are no longer the mechanism relied on for the api
itself to update.

Author: Ryanmello07

app/network/Authenticate/LoginNavigationView.swift

@@ -18,13 +18,24 @@ struct LoginNavigationView: View {
     @EnvironmentObject var deviceManager: DeviceManager
 
     var api: SdkApi
-    let urApiService: UrApiServiceProtocol
     var cancel: (() -> Void)? = nil
     var handleSuccess: (_ jwt: String) async -> Void
+
+    // Built from a live closure over `deviceManager.api` (an @EnvironmentObject,
+    // not available yet at init time) rather than the `api` snapshot passed
+    // in, so that switching the active network space (Settings > Change
+    // Network API) while this view is on screen is picked up immediately by
+    // every subsequent API call - including wallet-auth challenge/login,
+    // which previously kept hitting the network active when the login flow
+    // was first presented until the app was restarted.
+    private var urApiService: UrApiServiceProtocol {
+        UrApiService(apiProvider: { [weak deviceManager] in
+            deviceManager?.api ?? api
+        })
+    }
 
     init(api: SdkApi, cancel: (() -> Void)? = nil, handleSuccess: @escaping (_ jwt: String) async -> Void) {
         self.api = api
-        self.urApiService = UrApiService(api: api)
         self.cancel = cancel
         self.handleSuccess = handleSuccess
         _guestUpgradeViewModel = StateObject(wrappedValue: GuestUpgradeViewModel(api: api))

app/network/Shared/Services/UrApiService/UrApiService.swift

@@ -10,12 +10,41 @@ import URnetworkSdk
 
 class UrApiService: UrApiServiceProtocol {
 
-    private let api: SdkApi
+    // Resolved live on every call instead of captured once at init. This
+    // mirrors Android's `application.api` (a `get() = networkSpaceManagerProvider
+    // .getNetworkSpace()?.api` computed property) so that switching the
+    // active network space (Settings > Change Network API) is picked up
+    // immediately by any in-flight or new API call, without needing to
+    // tear down and recreate the whole view hierarchy that holds this
+    // service (which proved unreliable via SwiftUI .id() invalidation).
+    private let apiProvider: () -> SdkApi?
+    private var api: SdkApi? {
+        apiProvider()
+    }
 
     let domain = "UrApiService"
 
+    /// Fixed-api initializer, kept for call sites/tests that already have a
+    /// concrete `SdkApi` and don't need to react to network switches (e.g.
+    /// once a device is fully initialized and logged in, the api rarely
+    /// changes for the lifetime of that screen).
     init(api: SdkApi) {
-        self.api = api
+        self.apiProvider = { api }
+    }
+
+    /// Live-provider initializer. Pass a closure that always resolves the
+    /// current api (e.g. `{ deviceManager.api }`) so this service tracks
+    /// network-space changes made while the view using it is still on
+    /// screen (the login flow, most notably).
+    init(apiProvider: @escaping () -> SdkApi?) {
+        self.apiProvider = apiProvider
+    }
+
+    private func requireApi() throws -> SdkApi {
+        guard let api else {
+            throw NSError(domain: domain, code: -1, userInfo: [NSLocalizedDescriptionKey: "No active network API available"])
+        }
+        return api
     }
 
     private func nonEmptyJwt(_ jwt: String, context: String) -> Result<String, Error> {
@@ -37,6 +66,8 @@ extension UrApiService {
     func getLeaderboard() async throws -> [LeaderboardEntry] {
         let args = SdkGetLeaderboardArgs()
 
+        let api = try requireApi()
+        
         let result: SdkLeaderboardResult = try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetLeaderboardCallback { result, err in
@@ -59,7 +90,7 @@ extension UrApiService {
                 continuation.resume(returning: result)
             }
 
-            self.api.getLeaderboard(args, callback: callback)
+            api.getLeaderboard(args, callback: callback)
         }
 
         var earners: [LeaderboardEntry] = []
@@ -95,6 +126,8 @@ extension UrApiService {
      */
     func setNetworkRankingPublic(_ isPublic: Bool) async throws {
 
+        let api = try requireApi()
+        
         let _: SdkSetNetworkRankingPublicResult = try await withCheckedThrowingContinuation { continuation in
 
             let callback = SetLeaderboardVisibilityCallback { result, err in
@@ -132,6 +165,8 @@ extension UrApiService {
      */
     func getLeaderboardRanking() async throws -> SdkGetNetworkRankingResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetNetworkRankingCallback { result, err in
@@ -170,6 +205,7 @@ extension UrApiService {
         feedback: String,
         starCount: Int
     ) async throws -> SdkFeedbackSendResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = SendFeedbackCallback { result, err in
@@ -208,6 +244,7 @@ extension UrApiService {
      * Search providers
      */
     func searchProviders(_ query: String) async throws -> SdkFilteredLocations {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = FindLocationsCallback { result, err in
@@ -239,6 +276,7 @@ extension UrApiService {
      * Get all providers
      */
     func getAllProviders() async throws -> SdkFilteredLocations {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = FindLocationsCallback { result, err in
@@ -270,6 +308,7 @@ extension UrApiService {
 extension UrApiService {
 
     func authLogin(_ args: SdkAuthLoginArgs) async throws -> AuthLoginResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = AuthLoginCallback { result, error in
@@ -357,6 +396,7 @@ extension UrApiService {
     }
 
     func createNetwork(_ args: SdkNetworkCreateArgs) async throws -> LoginNetworkResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = NetworkCreateCallback { result, err in
@@ -402,6 +442,7 @@ extension UrApiService {
     }
 
     func upgradeGuest(_ args: SdkUpgradeGuestArgs) async throws -> LoginNetworkResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = UpgradeGuestCallback { result, err in
@@ -448,6 +489,8 @@ extension UrApiService {
 
     func createAuthCode() async throws -> SdkAuthCodeCreateResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = AuthCodeCreateCallback { result, err in
@@ -481,6 +524,7 @@ extension UrApiService {
     }
 
     func authCodeLogin(_ args: SdkAuthCodeLoginArgs) async throws -> SdkAuthCodeLoginResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = AuthCodeLoginCallback { result, err in
@@ -516,6 +560,7 @@ extension UrApiService {
     }
 
     func authWalletChallenge(_ args: SdkAuthWalletChallengeArgs) async throws -> SdkAuthWalletChallengeResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = AuthWalletChallengeCallback { result, err in
@@ -550,6 +595,7 @@ extension UrApiService {
 extension UrApiService {
 
     func validateReferralCode(_ code: String) async throws -> SdkValidateReferralCodeResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = ValidateReferralCallback { result, err in
@@ -584,6 +630,8 @@ extension UrApiService {
 
     func fetchSubscriptionBalance() async throws -> SdkSubscriptionBalanceResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetSubscriptionBalanceCallback { result, err in
@@ -609,6 +657,8 @@ extension UrApiService {
 
     func redeemBalanceCode(_ code: String) async throws -> SdkRedeemBalanceCodeResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = RedeemBalanceCodeCallback { result, err in
@@ -636,6 +686,7 @@ extension UrApiService {
     }
 
     func getRedeemedBalanceCodes() async throws -> SdkGetNetworkRedeemedBalanceCodesResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetNetworkRedeemedBalanceCodesCallback { result, err in
@@ -670,6 +721,8 @@ extension UrApiService {
 
     func blockLocation(_ locationId: SdkId) async throws -> SdkNetworkBlockLocationResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = BlockLocationCallback { result, err in
@@ -698,6 +751,8 @@ extension UrApiService {
 
     func unblockLocation(_ locationId: SdkId) async throws -> SdkNetworkUnblockLocationResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = UnblockLocationCallback { result, err in
@@ -726,6 +781,8 @@ extension UrApiService {
 
     func getBlockedLocations() async throws -> SdkGetNetworkBlockedLocationsResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetNetworkBlockedLocationsCallback { result, err in
@@ -756,6 +813,8 @@ extension UrApiService {
 
     func deleteAccount() async throws -> SdkNetworkDeleteResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = NetworkDeleteCallback { result, err in
@@ -782,6 +841,8 @@ extension UrApiService {
 
     func getReferralNetwork() async throws -> SdkGetReferralNetworkResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetNetworkReferralCallback { result, err in
@@ -806,6 +867,8 @@ extension UrApiService {
 
     func setNetworkReferral(_ referralCode: String) async throws -> SdkSetNetworkReferralResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = UpdateReferralNetworkCallback { result, err in
@@ -833,6 +896,7 @@ extension UrApiService {
     }
 
     func unlinkReferralNetwork() async throws -> SdkUnlinkReferralNetworkResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = UnlinkReferralNetworkCallback { result, err in
@@ -862,6 +926,8 @@ extension UrApiService {
 
     func getNetworkReliability() async throws -> SdkGetNetworkReliabilityResult {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetNetworkReliabilityCallback { result, err in
@@ -892,6 +958,8 @@ extension UrApiService {
 
     func validateWalletAddress(address: String, chain: String) async throws -> Bool {
 
+        let api = try requireApi()
+        
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = ValidateAddressCallback { result, err in
@@ -1160,6 +1228,7 @@ enum UpdateReferralNetworkError: Error {
 extension UrApiService {
 
     func getNetworkClients() async throws -> SdkNetworkClientsResult {
+        let api = try requireApi()
         return try await withCheckedThrowingContinuation { continuation in
 
             let callback = GetNetworkClientsCallback { result, err in
@@ -1183,6 +1252,7 @@ extension UrApiService {
     }
 
     func deviceSetName(deviceId: SdkId, deviceName: String) async throws -> Void {
+        let api = try requireApi()
         let _: SdkDeviceSetNameResult = try await withCheckedThrowingContinuation { continuation in
 
             let args = SdkDeviceSetNameArgs()