Merge pull request #172 from urnetwork/usability-fixes

Usability fixes

Author: xcolwell

connect.go

@@ -22,6 +22,11 @@ const MaxMultihopLength = 8
 //	Most clients need to be able to read v2 before we turn this on.
 const DefaultProtocolVersion = 2
 
+// v1: the first versioned stream version
+//
+//	this version requires that TransferPath allow simultaneous source, destination, and stream ids
+const DefaultStreamVersion = 1
+
 // id for message to/from the platform
 var ControlId = Id{}
 

ip_remote_multi_client.go

@@ -2770,7 +2770,7 @@ func (self *multiClientChannel) SendDetailedWithAck(parsedPacket *parsedPacket,
 		}
 
 		var opts []any
-		if self.performanceProfile.AllowDirect {
+		if self.performanceProfile != nil && self.performanceProfile.AllowDirect {
 			opts = append(opts, ForceStream())
 		}
 		if !ack {
@@ -2804,7 +2804,7 @@ func (self *multiClientChannel) SendDetailedMessage(message proto.Message, timeo
 		return false, err
 	} else {
 		var opts []any
-		if self.performanceProfile.AllowDirect {
+		if self.performanceProfile != nil && self.performanceProfile.AllowDirect {
 			opts = append(opts, ForceStream())
 		}
 		return self.client.SendMultiHopWithTimeoutDetailed(

ip_remote_multi_client_test.go

@@ -244,7 +244,7 @@ func TestMultiClientChannelWindowStats(t *testing.T) {
 	}
 	assert.Equal(t, nil, err)
 
-	clientChannel, err := newMultiClientChannel(ctx, channelArgs, generator, clientReceivePacket, DefaultIngressSecurityPolicy(), contractStatus, settings)
+	clientChannel, err := newMultiClientChannel(ctx, channelArgs, generator, clientReceivePacket, DefaultIngressSecurityPolicy(), contractStatus, nil, settings)
 	assert.Equal(t, nil, err)
 
 	cancelCtxs := []context.Context{}

ip_test.go

@@ -237,7 +237,7 @@ func testingNewClient(ctx context.Context, providerClient *Client, receivePacket
 			RequireMultiHopId(providerClient.ClientId()),
 		},
 		protocol.ProvideMode_Network,
-	)
+	), nil
 }
 
 // test with all sequence buffer sizes set to 0