Merge pull request #36 from urnetwork/fix/lint-errors

fix: clear the 12 pre-existing lint errors (1 React refs correctness fix + typing debt)

Author: Ryanmello07

src/background/index.ts

@@ -6,6 +6,7 @@ import { applyKillSwitchSetting } from "../utils/kill-switch-apply";
 import { isAllowedOrigin } from "../utils/origins";
 import { initBridge, notifySessionChanged, handleExtensionLocationChange } from "../bridge/background";
 import { startSsoFlow, clearSsoState, retrieveAndValidateState } from "../utils/sso";
+import type { FirefoxGlobal } from "../types/firefox-webext";
 
 const HEALTH_ALARM_NAME = "node-health-check";
 const MULTI_IP_SLOTS_KEY = "multi_ip_slots";
@@ -14,11 +15,11 @@ const MULTI_IP_SLOTS_KEY = "multi_ip_slots";
 initBridge();
 
 function isFirefox(): boolean {
-	return Boolean((globalThis as any).browser?.proxy?.onRequest);
+	return Boolean((globalThis as FirefoxGlobal).browser?.proxy?.onRequest);
 }
 
 // Register Firefox proxy error listener
-const firefoxProxy = (globalThis as any).browser?.proxy;
+const firefoxProxy = (globalThis as FirefoxGlobal).browser?.proxy;
 if (firefoxProxy?.onError) {
 	firefoxProxy.onError.addListener((error: { message: string }) => {
 		console.error("Firefox proxy error:", error.message);
@@ -107,7 +108,7 @@ chrome.alarms.onAlarm.addListener((alarm) => {
 
 // Firefox: restore proxy listener immediately — no need to wait for Chrome's
 // proxy.settings.get() to settle. The 2-second delay only benefits Chrome.
-if ((globalThis as any).browser?.proxy?.onRequest) {
+if ((globalThis as FirefoxGlobal).browser?.proxy?.onRequest) {
 	proxyManager.restoreState().catch((err) => {
 		console.error("Failed to restore Firefox proxy state on startup:", err);
 	});
@@ -123,7 +124,7 @@ if ((globalThis as any).browser?.proxy?.onRequest) {
 // The main flow now uses chrome.identity.launchWebAuthFlow, which delivers the
 // auth code directly to the extension via a browser-controlled redirect URL.
 // This listener is kept only as a safety net for any legacy/manual tab flow.
-chrome.tabs.onUpdated.addListener((tabId, changeInfo, _tab) => {
+chrome.tabs.onUpdated.addListener((tabId, changeInfo) => {
 	const url = changeInfo.url;
 	if (!url || !isSsoCompleteUrlLegacy(url)) return;
 

src/types/firefox-webext.d.ts

@@ -0,0 +1,61 @@
+/**
+ * The Firefox-only WebExtensions surface this extension actually touches.
+ *
+ * `@types/chrome` is the only extension typing installed, and it declares
+ * `chrome` alone -- nothing in the dependency tree declares Firefox's `browser`
+ * global. These declarations fill that gap.
+ *
+ * Only the members this codebase calls are declared; nothing is asserted about
+ * the rest of the namespace. Every member is optional because Chrome does not
+ * define `browser` at all and Firefox's request-level proxy API is
+ * version-dependent, so every call site feature-detects before using it.
+ */
+
+/** One proxy entry returned from a `proxy.onRequest` listener. */
+export type FirefoxProxyInfo = {
+	type: "http" | "https" | "socks" | "socks4" | "direct";
+	host?: string;
+	port?: number;
+	username?: string;
+	password?: string;
+	failoverTimeout?: number;
+};
+
+/** The request being proxied. Only `url` is read here. */
+export type FirefoxProxyDetails = {
+	url: string;
+};
+
+export type FirefoxProxyRequestListener = (
+	details: FirefoxProxyDetails,
+) => FirefoxProxyInfo[];
+
+export interface FirefoxProxyOnRequestEvent {
+	addListener(listener: FirefoxProxyRequestListener, filter: { urls: string[] }): void;
+	removeListener(listener: FirefoxProxyRequestListener): void;
+	hasListener(listener: FirefoxProxyRequestListener): boolean;
+}
+
+export interface FirefoxProxyOnErrorEvent {
+	addListener(listener: (error: { message: string }) => void): void;
+}
+
+export interface FirefoxProxyApi {
+	onRequest?: FirefoxProxyOnRequestEvent;
+	onError?: FirefoxProxyOnErrorEvent;
+}
+
+/**
+ * `globalThis` as seen from a Firefox WebExtension.
+ *
+ * Modelled as a cast target rather than a `declare global { var browser }` so
+ * `browser` stays unreachable as a bare identifier: on Chrome it is undeclared,
+ * and optional chaining does not guard an undeclared identifier -- `browser?.x`
+ * would throw a ReferenceError there, while `globalThis.browser?.x` is just a
+ * property read that yields `undefined`.
+ */
+export interface FirefoxGlobal {
+	browser?: {
+		proxy?: FirefoxProxyApi;
+	};
+}

src/utils/connection-manager.ts

@@ -5,6 +5,7 @@ import { chromeStorageAdapter } from "./storage-adapter";
 import { getKillSwitch } from "./kill-switch";
 import { buildAuthParams } from "./auth-params";
 import { clearBridgeSession } from "../bridge/session";
+import type { FirefoxGlobal } from "../types/firefox-webext";
 
 const MULTI_IP_SLOTS_KEY = "multi_ip_slots";
 
@@ -58,7 +59,7 @@ const MULTI_IP_PING_INTERVAL_S = 300;
 let lastPingAt = 0;
 
 function isFirefox(): boolean {
-	return Boolean((globalThis as any).browser?.proxy?.onRequest);
+	return Boolean((globalThis as FirefoxGlobal).browser?.proxy?.onRequest);
 }
 
 export class ConnectionManager {

src/utils/kill-switch-apply.ts

@@ -2,11 +2,12 @@ import { buildPacScript, pacScriptToDataUrl, type PacSlot } from "./pac-script";
 import { getSortedSlots, getStoredHealth } from "./node-health";
 import { setKillSwitch } from "./kill-switch";
 import { proxyManager } from "./proxy-manager";
+import type { FirefoxGlobal } from "../types/firefox-webext";
 
 const MULTI_IP_SLOTS_KEY = "multi_ip_slots";
 
 function isFirefox(): boolean {
-	return Boolean((globalThis as any).browser?.proxy?.onRequest);
+	return Boolean((globalThis as FirefoxGlobal).browser?.proxy?.onRequest);
 }
 
 // Persist + apply the kill-switch setting. Shared by the popup message handler

src/utils/proxy-manager.ts

@@ -1,6 +1,13 @@
 import type { PacSlot } from "./pac-script";
 import { shouldBypass, chromeBypassList, deviceRpcApiHost } from "./bypass-rules";
 import { getKillSwitch } from "./kill-switch";
+import type {
+	FirefoxGlobal,
+	FirefoxProxyApi,
+	FirefoxProxyDetails,
+	FirefoxProxyInfo,
+	FirefoxProxyRequestListener,
+} from "../types/firefox-webext";
 
 export interface ProxyConfig {
 	host: string;
@@ -23,21 +30,8 @@ const STORAGE_KEYS = {
 	CONFIG: "proxy_config",
 } as const;
 
-type FirefoxProxyInfo = {
-	type: "http" | "https" | "socks" | "socks4" | "direct";
-	host?: string;
-	port?: number;
-	username?: string;
-	password?: string;
-	failoverTimeout?: number;
-};
-
-type FirefoxProxyDetails = {
-	url: string;
-};
-
-function getFirefoxProxyApi(): any | null {
-	return (globalThis as any).browser?.proxy ?? null;
+function getFirefoxProxyApi(): FirefoxProxyApi | null {
+	return (globalThis as FirefoxGlobal).browser?.proxy ?? null;
 }
 
 function isFirefoxProxyApiAvailable(): boolean {
@@ -51,7 +45,7 @@ function firefoxProxyType(scheme: ProxyConfig["scheme"]): FirefoxProxyInfo["type
 class ProxyManager {
 	private state: ProxyState = { enabled: false, mode: "direct", config: null };
 	private firefoxConfig: ProxyConfig | null = null;
-	private firefoxListener: ((details: FirefoxProxyDetails) => FirefoxProxyInfo[]) | null = null;
+	private firefoxListener: FirefoxProxyRequestListener | null = null;
 	private firefoxMultiIpSlots: PacSlot[] = [];
 	private killSwitchEnabled = true;
 
@@ -77,8 +71,9 @@ class ProxyManager {
 		}
 	}
 
-	private ensureFirefoxListener(): void {
-		if (this.firefoxListener) return;
+	/** Returns the single-proxy listener, creating it on first use. */
+	private ensureFirefoxListener(): FirefoxProxyRequestListener {
+		if (this.firefoxListener) return this.firefoxListener;
 
 		this.firefoxListener = (details: FirefoxProxyDetails): FirefoxProxyInfo[] => {
 			const config = this.firefoxConfig;
@@ -108,24 +103,26 @@ class ProxyManager {
 			}
 			return [proxyInfo, { type: "direct" }];
 		};
+
+		return this.firefoxListener;
 	}
 
 	private addFirefoxProxyListener(config: ProxyConfig): void {
 		const firefoxProxyApi = getFirefoxProxyApi();
 		if (!firefoxProxyApi?.onRequest) return;
 
-		this.ensureFirefoxListener();
+		const listener = this.ensureFirefoxListener();
 		this.firefoxConfig = config;
 
 		try {
-			if (firefoxProxyApi.onRequest.hasListener(this.firefoxListener)) {
-				firefoxProxyApi.onRequest.removeListener(this.firefoxListener);
+			if (firefoxProxyApi.onRequest.hasListener(listener)) {
+				firefoxProxyApi.onRequest.removeListener(listener);
 			}
 		} catch {
 			// Ignore stale listener cleanup failures.
 		}
 
-		firefoxProxyApi.onRequest.addListener(this.firefoxListener, {
+		firefoxProxyApi.onRequest.addListener(listener, {
 			urls: ["<all_urls>"],
 		});
 	}
@@ -151,7 +148,11 @@ class ProxyManager {
 	enableMultiIp(slots: PacSlot[]): void {
 		if (!isFirefoxProxyApiAvailable() || slots.length === 0) return;
 
-		const firefoxProxyApi = getFirefoxProxyApi();
+		const onRequest = getFirefoxProxyApi()?.onRequest;
+		// isFirefoxProxyApiAvailable() above already established this; the explicit
+		// check is what narrows the optional event for the type checker.
+		if (!onRequest) return;
+
 		this.removeFirefoxProxyListener();
 
 		this.firefoxMultiIpSlots = slots;
@@ -182,7 +183,7 @@ class ProxyManager {
 			return proxies;
 		};
 
-		firefoxProxyApi.onRequest.addListener(this.firefoxListener, {
+		onRequest.addListener(this.firefoxListener, {
 			urls: ["<all_urls>"],
 		});
 

src/utils/sso.ts

@@ -48,7 +48,7 @@ function launchWebAuthFlow(options: WebAuthFlowOptions): Promise<string | undefi
 		identity.launchWebAuthFlow(options, (responseUrl) => {
 			const err =
 				chrome.runtime?.lastError?.message ||
-				(typeof browser !== "undefined" && (browser as any).runtime?.lastError?.message);
+				(typeof browser !== "undefined" && browser.runtime?.lastError?.message);
 			if (err) {
 				reject(new Error(err));
 				return;

src/utils/use-connection-manager.ts

@@ -22,10 +22,24 @@ export function useConnectionManager(): UseConnectionManagerResult {
 	const proxyChangeCbRef = useRef<((config: null) => void) | null>(null);
 	const managerRef = useRef<ConnectionManager | null>(null);
 
+	// The ConnectionManager is created once and outlives the renders that produce
+	// these two SDK callbacks, so it reads them through refs instead of capturing
+	// them directly (recreating the manager would drop the live connection pool,
+	// ping interval and renew timer).
+	//
+	// Refresh the refs from a commit, never from render. A render can be thrown
+	// away, and a render-phase write would let a render that never committed
+	// publish its callback into the manager -- which invokes them from timers
+	// (silentRenew, scheduleReconnect) long after any render has finished. An
+	// effect with no dependency array runs after every commit, which is exactly
+	// the "latest committed value" semantics wanted here; the useRef seeds mean
+	// there is never an empty ref before the first commit.
 	const authFnRef = useRef(authNetworkClient);
 	const removeFnRef = useRef(removeNetworkClient);
-	authFnRef.current = authNetworkClient;
-	removeFnRef.current = removeNetworkClient;
+	useEffect(() => {
+		authFnRef.current = authNetworkClient;
+		removeFnRef.current = removeNetworkClient;
+	});
 
 	const getManager = useCallback((): ConnectionManager => {
 		if (!managerRef.current) {

src/utils/use-provider-list-enhanced.ts

@@ -190,7 +190,7 @@ export function useProviderListEnhanced() {
 			let result: FindLocationsResult;
 
 			if (searchQuery.length === 0) {
-				result = await (api as any).networkProviderLocations();
+				result = await api.networkProviderLocations();
 			} else {
 				const response = await fetch(`${API_BASE}/network/find-provider-locations`, {
 					method: "POST",