Skip to content

Commit aedaa97

Browse files
committed
redis: adjust pool settings
1 parent 3ce6e71 commit aedaa97

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

redis.go

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func (self *safeRedisClient) open() redis.Cmdable {
3232

3333
minConnections := redisConfigKeys.RequireInt("min_connections")
3434
maxConnections := redisConfigKeys.RequireInt("max_connections")
35-
maxRetries := 32
35+
maxRetries := 8
3636
connectionMaxLifetime := "1h"
3737
connectionMaxIdleTime := "5m"
3838
if allMaxRetries := redisConfigKeys.Int("max_retries"); 0 < len(allMaxRetries) {
@@ -74,9 +74,10 @@ func (self *safeRedisClient) open() redis.Cmdable {
7474

7575
readTimeout := 30 * time.Second
7676
writeTimeout := 15 * time.Second
77+
dialTimeout := 30 * time.Second
7778

7879
dialer := &net.Dialer{
79-
Timeout: 90 * time.Second,
80+
Timeout: dialTimeout,
8081
KeepAliveConfig: net.KeepAliveConfig{
8182
Enable: true,
8283
},
@@ -102,6 +103,8 @@ func (self *safeRedisClient) open() redis.Cmdable {
102103
MaxRetries: maxRetries,
103104
MinIdleConns: minConnections,
104105
MaxIdleConns: maxConnections,
106+
PoolSize: minConnections,
107+
MaxActiveConns: maxConnections,
105108
ConnMaxLifetime: connectionMaxLifetimeDuration,
106109
ConnMaxIdleTime: connectionMaxIdleTimeDuration,
107110
// see https://redis.uptrace.dev/guide/go-redis-debugging.html#timeouts
@@ -110,6 +113,8 @@ func (self *safeRedisClient) open() redis.Cmdable {
110113
ReadTimeout: readTimeout,
111114
WriteTimeout: writeTimeout,
112115
Dialer: dialContext,
116+
// DialerRetries: maxRetries,
117+
DialTimeout: dialTimeout,
113118
}
114119
self.client = redis.NewClusterClient(options)
115120
} else {
@@ -124,6 +129,8 @@ func (self *safeRedisClient) open() redis.Cmdable {
124129
MaxRetries: maxRetries,
125130
MinIdleConns: minConnections,
126131
MaxIdleConns: maxConnections,
132+
PoolSize: minConnections,
133+
MaxActiveConns: maxConnections,
127134
ConnMaxLifetime: connectionMaxLifetimeDuration,
128135
ConnMaxIdleTime: connectionMaxIdleTimeDuration,
129136
// see https://redis.uptrace.dev/guide/go-redis-debugging.html#timeouts
@@ -132,6 +139,8 @@ func (self *safeRedisClient) open() redis.Cmdable {
132139
ReadTimeout: readTimeout,
133140
WriteTimeout: writeTimeout,
134141
Dialer: dialContext,
142+
// DialerRetries: maxRetries,
143+
DialTimeout: dialTimeout,
135144
}
136145
self.client = redis.NewClient(options)
137146
}

0 commit comments

Comments
 (0)