nclm: update pass in parallel count standard pattern

Author: xcolwell

model/network_client_location_model.go

@@ -2180,7 +2180,7 @@ func clientScoreLocationGroupSampleKey(forceMinimum bool, rankMode RankMode, loc
 	return fmt.Sprintf("css_%d_%c_g_%s_%s_%d", fm, rm, locationGroupId, callerLocationId, index)
 }
 
-func UpdateClientScores(ctx context.Context, ttl time.Duration) (returnErr error) {
+func UpdateClientScores(ctx context.Context, ttl time.Duration, parallel int) (returnErr error) {
 	addClientScore := func(lookbackClientScore *ClientScore, m map[server.Id]*ClientScore) *ClientScore {
 		clientScore, ok := m[lookbackClientScore.ClientId]
 		if !ok {
@@ -2669,16 +2669,15 @@ func UpdateClientScores(ctx context.Context, ttl time.Duration) (returnErr error
 	}
 	clientLocationIds = append(clientLocationIds, maps.Values(countryCodeLocationIds())...)
 
-	n := 48
-	m := (len(clientLocationIds) + n - 1) / n
+	m := (len(clientLocationIds) + parallel - 1) / parallel
 	allBlockClientLocationIds := [][]server.Id{}
 	for i := 0; i < len(clientLocationIds); i += m {
 		allBlockClientLocationIds = append(allBlockClientLocationIds, clientLocationIds[i:min(len(clientLocationIds), i+m)])
 	}
 
 	var wg sync.WaitGroup
 	var exportCount atomic.Uint32
-	returnErrs := make(chan error, n)
+	returnErrs := make(chan error, parallel)
 
 	for i := 0; i < len(clientLocationIds); i += m {
 		blockClientLocationIds := clientLocationIds[i:min(len(clientLocationIds), i+m)]

model/network_client_location_model_test.go

@@ -238,7 +238,7 @@ func TestBestAvailableProviders(t *testing.T) {
 			stats,
 		)
 		UpdateClientReliabilityScores(ctx, server.NowUtc(), true)
-		UpdateClientScores(ctx, 5*time.Second)
+		UpdateClientScores(ctx, 5*time.Second, 1)
 
 		res, err := FindProviders2(findProviders2Args, clientSessionA)
 		assert.Equal(t, err, nil)
@@ -349,7 +349,7 @@ func TestFindProviders2WithExclude(t *testing.T) {
 		}
 
 		UpdateClientReliabilityScores(ctx, server.NowUtc().Add(time.Hour), true)
-		UpdateClientScores(ctx, 5*time.Second)
+		UpdateClientScores(ctx, 5*time.Second, 1)
 
 		clientIds := maps.Keys(clientSessions)
 		clientIdA := clientIds[0]

taskworker/work/network_client_location_work.go

@@ -35,7 +35,7 @@ func UpdateClientScores(
 	clientSession *session.ClientSession,
 ) (*UpdateClientScoresResult, error) {
 	ttl := 300 * time.Minute
-	err := model.UpdateClientScores(clientSession.Ctx, ttl)
+	err := model.UpdateClientScores(clientSession.Ctx, ttl, 48)
 	if err != nil {
 		return nil, err
 	}