Skip to content

fix: src path canonicalizing fix#35

Merged
uroybd merged 2 commits intomainfrom
path-normalization-refactor
Nov 28, 2025
Merged

fix: src path canonicalizing fix#35
uroybd merged 2 commits intomainfrom
path-normalization-refactor

Conversation

@uroybd
Copy link
Owner

@uroybd uroybd commented Nov 28, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 28, 2025 16:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes path canonicalization issues by preserving symlinks and trailing slashes when resolving destination paths. The changes simplify the path handling logic and remove redundant backup confirmation messages.

  • Refactored path resolution to use the resolved path directly without canonicalization, preserving symlinks
  • Added logic to preserve trailing slashes from the original path when applicable
  • Removed duplicate "Backed up" print statements during backup operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

📊 Coverage Report

Overall Coverage: 94.32%

Full coverage report available in Codecov

Coverage Details

The coverage report has been generated and uploaded to Codecov.

  • Target: 70%
  • Patch Target: 80%

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.84%. Comparing base (a145f6c) to head (19369a5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/package/mod.rs 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   94.85%   94.84%   -0.01%     
==========================================
  Files           6        6              
  Lines        1088     1086       -2     
==========================================
- Hits         1032     1030       -2     
  Misses         56       56              
Files with missing lines Coverage Δ
src/package/mod.rs 95.12% <87.50%> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a145f6c...19369a5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@uroybd uroybd merged commit 4323200 into main Nov 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants