test(e2e): migrate nerdctl tests to Ginkgo framework#500
Merged
cmainas merged 1 commit intourunc-dev:main-pr500from Feb 25, 2026
Merged
Conversation
✅ Deploy Preview for urunc canceled.
|
IrvingMg
force-pushed
the
enhance/e2e-migrate-nerdctl-suite-to-ginkgo
branch
2 times, most recently
from
8252ca5 to
91f245e
Compare
cmainas
reviewed
Feb 20, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Thank you @IrvingMg for the changes.
Everything looks good, just one request. Let's remove the kvm group discovery and setting in the arguments of the container, since it is no longer needed. However, could you do that in a separate commit so we can easily distinguish it from the rest of the refactor?
4 tasks
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
IrvingMg
force-pushed
the
enhance/e2e-migrate-nerdctl-suite-to-ginkgo
branch
from
91f245e to
9f3e65c
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
PR: #500 Signed-off-by: Irving Mondragón <mirvingr@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
PR: #500 Signed-off-by: Irving Mondragón <mirvingr@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the
nerdctle2e tests from the standard Go testing package to Ginkgo. This includes changes such as:TestCtrtoTestE2Eso that all Ginkgo specs run under a single function. The Makefile targets use--ginkgo.focusto select which suite (Ctr or Nerdctl) to run.BeforeEachlogic inctr_test.goby introducing a sharedsetupTestDirhelper.Related issues
How was this tested?
make test_nerdctlmake test_nerdctl_Qemumake test_ctr_HvtLLM usage
Claude Code (Opus 4.6)
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).