refactor(e2e): deduplicate DescribeTable bodies across tools#537
Conversation
✅ Deploy Preview for urunc canceled.
|
|
@cmainas Since this PR closes the Ginkgo migration issue, should I update the description to also close these two related issues? |
cmainas
left a comment
There was a problem hiding this comment.
Thank you @IrvingMg for this PR.
I only have one comment for the crictl's pod creation. Other than that everything looks good.
For #200, let's keep it open because we still experience a lot of failures due to image pulling. One approach is to migrate the test images to docker (#444).
For #207, the ginkgo migration has definitely improved the error messages and we also capture the urunc debug logs. Would it be possible to also get the contianer's logs, when we have an error in starting it? If the error takes place on the create step, then there will be no logs.
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
214195c to
20df3a4
Compare
|
Thanks for reviewing!
I see, makes sense.
Sure, I’ll create a separate PR for that change and then close #207. |
PR: #537 Signed-off-by: Irving Mondragón <mirvingr@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
PR: #537 Signed-off-by: Irving Mondragón <mirvingr@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Description
As discussed in #527 (review), this cleanup commonizes the e2e tests logic.
Related issues
Since this is the last PR for the migration of e2e tests to Ginkgo
How was this tested?
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).