Skip to content

refactor(e2e): deduplicate DescribeTable bodies across tools#537

Merged
cmainas merged 1 commit intourunc-dev:main-pr537from
IrvingMg:refactor/commonize-e2e-test-logic
Mar 30, 2026
Merged

refactor(e2e): deduplicate DescribeTable bodies across tools#537
cmainas merged 1 commit intourunc-dev:main-pr537from
IrvingMg:refactor/commonize-e2e-test-logic

Conversation

@IrvingMg
Copy link
Copy Markdown
Contributor

Description

As discussed in #527 (review), this cleanup commonizes the e2e tests logic.

Related issues

Since this is the last PR for the migration of e2e tests to Ginkgo

How was this tested?

  • make e2etest

LLM usage

N/A

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2026

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 20df3a4
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/69c68b5e65367500085303b4

@IrvingMg
Copy link
Copy Markdown
Contributor Author

@cmainas Since this PR closes the Ginkgo migration issue, should I update the description to also close these two related issues?

Copy link
Copy Markdown
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IrvingMg for this PR.

I only have one comment for the crictl's pod creation. Other than that everything looks good.

For #200, let's keep it open because we still experience a lot of failures due to image pulling. One approach is to migrate the test images to docker (#444).

For #207, the ginkgo migration has definitely improved the error messages and we also capture the urunc debug logs. Would it be possible to also get the contianer's logs, when we have an error in starting it? If the error takes place on the create step, then there will be no logs.

Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
@IrvingMg IrvingMg force-pushed the refactor/commonize-e2e-test-logic branch from 214195c to 20df3a4 Compare March 27, 2026 13:51
@IrvingMg
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing!

For #200, let's keep it open because we still experience a lot of failures due to image pulling. One approach is to migrate the test images to docker (#444).

I see, makes sense.

For #207, the ginkgo migration has definitely improved the error messages and we also capture the urunc debug logs. Would it be possible to also get the contianer's logs, when we have an error in starting it? If the error takes place on the create step, then there will be no logs.

Sure, I’ll create a separate PR for that change and then close #207.

@urunc-bot urunc-bot bot changed the base branch from main to main-pr537 March 30, 2026 12:42
Copy link
Copy Markdown
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IrvingMg for the cleanup. It looks good.

@cmainas cmainas merged commit 910edd1 into urunc-dev:main-pr537 Mar 30, 2026
57 of 58 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 30, 2026
PR: #537
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot bot pushed a commit that referenced this pull request Mar 30, 2026
PR: #537
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
@IrvingMg IrvingMg deleted the refactor/commonize-e2e-test-logic branch March 31, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate E2E tests to Ginkgo framework

2 participants