fix(netwotk): Get MTU from tap device and set it in Qemu and clh args#564
Merged
urunc-bot[bot] merged 1 commit intomainfrom Apr 15, 2026
Merged
fix(netwotk): Get MTU from tap device and set it in Qemu and clh args#564urunc-bot[bot] merged 1 commit intomainfrom
urunc-bot[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for urunc canceled.
|
Contributor
|
thanks @cmainas! looks good -- just a note for future reference, FC support is under way, pending merge of firecracker-microvm/firecracker#5828. Solo5 should detect that, I believe we have raised that in Solo5/solo5#605 and should be resolved after: Solo5/solo5#606 |
ananos
approved these changes
Apr 15, 2026
Qemu and Cloud hypervisor support setting the MTU value in the command line arguments of the network device. Therefore, get the MTU value from the network interface of the host that we associate with the tap device and set it as the MTU for Qemu's and cloud hypervisor's virtio network device. PR: #564 Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
c2e66da to
02a2512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Qemu and Cloud hypervisor support setting the MTU value in the command line arguments of the network device. Therefore, get the MTU value from the network interface of the host that we associate with the tap device and set it as the MTU for Qemu's and cloud hypervisor's virtio network device.
Related issues
Related to #547 but since Firecracker does not accept any option to set the MTU or to retrieve it form the tap device, the issue will remain open.
How was this tested?
In a k3s environment using flannel, which uses 1450 for MTU, qemu and clh based images where deployed and checked the MTUs of the network interface inside the VM.
e.g. for a pod configuration:
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).