feat: Allow nightly tests to pass#579
Merged
urunc-bot[bot] merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
✅ Deploy Preview for urunc canceled.
|
cmainas
approved these changes
Apr 28, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Seems reasonable, Let's hope, we will not need to increase it even more.
Until we fix our upload (or move to docker for storing our test images), let's increase the timeout to 20' so that nightly tests pass. It seems that pulling the images for nerdctl takes ~14' and the timeout was 15'. PR: #579 Signed-off-by: Anastassios Nanos <ananos@nubificus.co.uk> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
github-actions
Bot
force-pushed
the
fix_tests_timeout
branch
from
e8dd664 to
6411ba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until we fix our upload (or move to docker for storing our test images), let's increase the timeout to 20' so that nightly tests pass. It seems that pulling the images for nerdctl takes ~14' and the timeout was 15'.
Related issues
Nightly tests fail almost every time.
How was this tested?
Temp. Increase the timeout
LLM usage
No LLM used
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).